From: Mira Limbeck <m.limbeck@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: tape: restore: fix default namespace mapping
Date: Mon, 2 Oct 2023 12:16:37 +0200 [thread overview]
Message-ID: <3cdbab95-4aea-5b02-5f40-d4be27ea48a2@proxmox.com> (raw)
In-Reply-To: <20231002075229.3055009-1-d.csapak@proxmox.com>
On 10/2/23 09:52, Dominik Csapak wrote:
> the ui shows the default 'root' namespace as target, but this only
> worked when no namespace was selected. as soon as one source datastore
> had a target namespace selected, the others datastores would be skipped
> as there was no namespace mapping for them. To fix that, we simply send
> a default namespace mapping for each source datastore without a target
> (no target means 'root')
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/tape/window/TapeRestore.js | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
> index c1d3493c..988ceba2 100644
> --- a/www/tape/window/TapeRestore.js
> +++ b/www/tape/window/TapeRestore.js
> @@ -537,6 +537,8 @@ Ext.define('PBS.TapeManagement.DataStoreMappingGrid', {
> let ns = targetns || defaultNs;
> if (ns) {
> namespaces.push(`store=${source},target=${ns}`);
> + } else {
> + namespaces.push(`store=${source}`);
> }
> }
> });
Worked as expected in my tests. Consider it:
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
one thing that popped up, unrelated to this patch, it seems the
datastore order in the mapping form changes sometimes.
next prev parent reply other threads:[~2023-10-02 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 7:52 Dominik Csapak
2023-10-02 10:16 ` Mira Limbeck [this message]
2023-10-03 11:20 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cdbab95-4aea-5b02-5f40-d4be27ea48a2@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox