From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox v2 2/3] proxmox-sys: add DiskUsage struct and helper
Date: Thu, 16 Dec 2021 09:20:12 +0100 [thread overview]
Message-ID: <3c14a5fa-3422-504c-bfa3-8da9494d2271@proxmox.com> (raw)
In-Reply-To: <a31554ba-7097-1bc6-1bb8-cfdf18ad6722@proxmox.com>
On 16.12.21 09:15, Dominik Csapak wrote:
> On 12/15/21 13:41, Thomas Lamprecht wrote:
>> On 15.12.21 10:19, Dominik Csapak wrote:
>>> @@ -102,3 +103,28 @@ impl CreateOptions {
>>> */
>>> }
>>> +/// Basic disk usage information
>>
>> would add the source, e.g.: ... derived from what statfs64 reports
>>
>>> +#[derive(Serialize)]
>>> +pub struct DiskUsage {
>>
>> Is DiskUsage really a good name here? As with "Disk" I thing block level, but
>> this is filesystem level.. Maybe FileSystemUsage (shorteting to FSUsage could
>> be done, but that's not helping that much..
>
> how about FileSystemInformation (or FSInfo if the length is a problem)? IMHO "usage" is wrong if we include things like the type or id
not really wrong to include an ID to any info for tracking purpose, I mean the
syscall also returns that and is named "StatFS", so that's fine, its wrong to
name it disk, but using "info" or "usage" won't create any big confusion either
way IMO, no hard feelings there.
next prev parent reply other threads:[~2021-12-16 8:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 9:19 [pbs-devel] [PATCH proxmox/proxmox-backup v2] add metrics server capability Dominik Csapak
2021-12-15 9:19 ` [pbs-devel] [PATCH proxmox v2 1/3] proxmox-sys: make some structs serializable Dominik Csapak
2021-12-15 9:19 ` [pbs-devel] [PATCH proxmox v2 2/3] proxmox-sys: add DiskUsage struct and helper Dominik Csapak
2021-12-15 12:41 ` Thomas Lamprecht
2021-12-16 8:15 ` Dominik Csapak
2021-12-16 8:20 ` Thomas Lamprecht [this message]
2021-12-15 9:19 ` [pbs-devel] [PATCH proxmox v2 3/3] proxmox-metrics: implement metrics server client code Dominik Csapak
2021-12-15 9:19 ` [pbs-devel] [PATCH proxmox-backup v2 1/6] use 'disk_usage' from proxmox-sys Dominik Csapak
2021-12-15 9:19 ` [pbs-devel] [PATCH proxmox-backup v2 2/6] pbs-api-types: add metrics api types Dominik Csapak
2021-12-15 9:19 ` [pbs-devel] [PATCH proxmox-backup v2 3/6] pbs-config: add metrics config class Dominik Csapak
2021-12-15 9:19 ` [pbs-devel] [PATCH proxmox-backup v2 4/6] backup-proxy: decouple stats gathering from rrd update Dominik Csapak
2021-12-15 9:19 ` [pbs-devel] [PATCH proxmox-backup v2 5/6] proxmox-backup-proxy: send metrics to configured metrics server Dominik Csapak
2021-12-15 9:19 ` [pbs-devel] [PATCH proxmox-backup v2 6/6] api: add metricserver endpoints Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c14a5fa-3422-504c-bfa3-8da9494d2271@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox