From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup] ui: sync job: fix source group filters based on sync direction
Date: Mon, 25 Nov 2024 15:23:55 +0100 [thread overview]
Message-ID: <39c2cd0a-981d-4b7d-80ce-b828634eb4b9@proxmox.com> (raw)
In-Reply-To: <20241125110323.169074-1-c.ebner@proxmox.com>
seems good to me now, and works as intended from my tests)
in general I'd like to think a bit harder about how we can make that better so we don't have
to manually write the update in so many different places with various conditions, but for
now it seems good enough
(e.g. I could imagine using viewmodels here might help? or custom events
that the gridfilter could listen to...)
anyway, consider this
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-25 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 11:03 Christian Ebner
2024-11-25 14:23 ` Dominik Csapak [this message]
2024-11-25 14:50 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39c2cd0a-981d-4b7d-80ce-b828634eb4b9@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox