From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: prune job edit: fix disabling jobs
Date: Wed, 16 Nov 2022 10:41:40 +0100 [thread overview]
Message-ID: <3997d53a-39c9-ed95-38b2-b82b73a19ae2@proxmox.com> (raw)
In-Reply-To: <3c73f48e-1477-f75c-6d69-bda1d5b414bb@proxmox.com>
Am 15.11.22 um 15:29 schrieb Thomas Lamprecht:
> Am 14/11/2022 um 10:42 schrieb Fiona Ebner:
>> The backend doesn't have an 'enable' option, but 'disable'. Could be
>> converted before sending and after loading, but it's cleaner to just
>> align it with the backend.
>
> while it is cleaner code-wise, its worse UX-wise; as checking (=enabling) a
> "negative" option like disable is always a bit odd and in general a bit less
> intuitive.
>
> I replaced this by a patch that converts it on load/before send to keep the
> "Enable" display.
Makes sense, thanks! For PBS 3.0, should we align it with sync and
verify jobs where the schedule is optional (so disabled if no schedule
is set)? That would close #4342.
prev parent reply other threads:[~2022-11-16 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 9:42 Fiona Ebner
2022-11-14 10:54 ` Dominik Csapak
2022-11-14 13:26 ` Fabian Grünbichler
2022-11-14 14:01 ` Dominik Csapak
2022-11-15 14:29 ` Thomas Lamprecht
2022-11-16 9:41 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3997d53a-39c9-ed95-38b2-b82b73a19ae2@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox