From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup ] datastore maintenance mode update: correctly track maintenance mode changes
Date: Wed, 17 Apr 2024 17:49:36 +0200 (CEST) [thread overview]
Message-ID: <39644187.7950.1713368976191@webmail.proxmox.com> (raw)
In-Reply-To: <D0MESUPS491X.2VMPO7V54UFM5@proxmox.com>
> technically yes, but we only use this to determine if we have to clear a
> cache entry, and putting a datastore out of maintenance never requires
> the dropping the cache entry
If so, variable naming is terrible. It is called "maintenance_mode_changed" - can you see whats wrong with that?
>
> On Wed Apr 17, 2024 at 2:19 PM CEST, Dietmar Maurer wrote:
> > Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
> > ---
> > src/api2/config/datastore.rs | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/api2/config/datastore.rs b/src/api2/config/datastore.rs
> > index 3081e1f4..dc658e35 100644
> > --- a/src/api2/config/datastore.rs
> > +++ b/src/api2/config/datastore.rs
> > @@ -276,6 +276,8 @@ pub fn update_datastore(
> >
> > let mut data: DataStoreConfig = config.lookup("datastore", &name)?;
> >
> > + let mut maintenance_mode_changed = false;
> > +
> > if let Some(delete) = delete {
> > for delete_prop in delete {
> > match delete_prop {
> > @@ -319,6 +321,9 @@ pub fn update_datastore(
> > data.tuning = None;
> > }
> > DeletableProperty::MaintenanceMode => {
> > + if data.maintenance_mode.is_some() && data.update.maintenance_mode.is_none() {
> > + maintenance_mode_changed = true;
> > + }
> > data.maintenance_mode = None;
> > }
> > }
> > @@ -389,7 +394,6 @@ pub fn update_datastore(
> > data.tuning = update.tuning;
> > }
> >
> > - let mut maintenance_mode_changed = false;
> > if update.maintenance_mode.is_some() {
> > maintenance_mode_changed = data.maintenance_mode != update.maintenance_mode;
> > data.maintenance_mode = update.maintenance_mode;
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-04-17 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 12:19 Dietmar Maurer
2024-04-17 12:50 ` Hannes Laimer
2024-04-17 15:49 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39644187.7950.1713368976191@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox