From: Christian Ebner <c.ebner@proxmox.com>
To: Robert Obkircher <r.obkircher@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH v1 proxmox-backup 0/3] fix incremental qemu backup
Date: Tue, 10 Mar 2026 18:34:52 +0100 [thread overview]
Message-ID: <3788bc07-64bd-42f7-9528-ec4a9186b5d8@proxmox.com> (raw)
In-Reply-To: <20260310160537.182153-1-r.obkircher@proxmox.com>
On 3/10/26 5:08 PM, Robert Obkircher wrote:
> Fix a bug, improve api docs, and disallow API usage that we don't need.
>
> Robert Obkircher (3):
> api: backup: don't verify total file size for incremental backups
> api: backup: improve schema documentation of fixed_close
> api: backup: disallow incremental backups with different index length
>
> src/api2/backup/environment.rs | 14 +++++++-------
> src/api2/backup/mod.rs | 15 ++++++++++++++-
> 2 files changed, 21 insertions(+), 8 deletions(-)
>
Thanks for the quick fix and sorry that this slipped trough during
review/testing.
Also can confirm that this fixes the incremental backups with dirty
bitmap tracking as used by proxmox-backup-qemu.
Tested new and incremental VM backup.
Confirmed streaming backup inputs via /dev/stdin still works as
expected, also when done incrementally.
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>
next prev parent reply other threads:[~2026-03-10 17:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 16:03 Robert Obkircher
2026-03-10 16:03 ` [PATCH v1 proxmox-backup 1/3] api: backup: don't verify total file size for incremental backups Robert Obkircher
2026-03-10 17:03 ` Christian Ebner
2026-03-10 18:23 ` Thomas Lamprecht
2026-03-10 16:03 ` [PATCH v1 proxmox-backup 2/3] api: backup: improve schema documentation of fixed_close Robert Obkircher
2026-03-10 17:09 ` Christian Ebner
2026-03-10 16:04 ` [PATCH v1 proxmox-backup 3/3] api: backup: disallow incremental backups with different index length Robert Obkircher
2026-03-10 17:16 ` Christian Ebner
2026-03-10 18:40 ` Thomas Lamprecht
2026-03-10 17:11 ` [PATCH v1 proxmox-backup 0/3] fix incremental qemu backup Stoiko Ivanov
2026-03-10 17:34 ` Christian Ebner [this message]
2026-03-10 18:59 ` applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3788bc07-64bd-42f7-9528-ec4a9186b5d8@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=r.obkircher@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox