Re: [pbs-devel] [PATCH proxmox-backup 0/6] sync job ui improvements

[Christian Ebner <c.ebner@proxmox.com>]

On 11/25/24 12:15, Dominik Csapak wrote:
> this series aims to improve the pull/push sync job ui a bit, by:
> 
> * unifying both types into one list

Not sure if you are aware of this, but we decided early on [0] to 
explicitly separate the list for both directions to reduce possible 
misconfiguration for the user. That is also why the sync jobs in push 
direction have their dedicated config type instead of having the 
direction as property of the sync job.

[0] 
https://lore.proxmox.com/pbs-devel/5be4c3d1-593f-4eec-b21b-33cb3afc9216@proxmox.com/

> * adding a helpful tooltip for local owner/user
> * adding a filter for the sync jobs
> * adding a 'all' mode for listing all jobs on the /admin/sync api
> 
> Dominik Csapak (6):
>    api: admin: sync: add direction to sync job status
>    api: admin: sync: add optional 'all' sync type for listing
>    cli: manager: sync: add 'sync-direction' parameter to list
>    ui: sync jobs: revert to single list for pull/push jobs
>    ui: sync jobs: change default sorting to 'store' -> 'direction' ->
>      'id'
>    ui: sync jobs: add search box
> 
>   pbs-api-types/src/jobs.rs              |   6 ++
>   src/api2/admin/sync.rs                 |  65 ++++++++----
>   src/api2/config/datastore.rs           |   9 +-
>   src/api2/config/notifications/mod.rs   |   2 +-
>   src/bin/proxmox_backup_manager/sync.rs |   6 +-
>   www/Makefile                           |   1 -
>   www/config/SyncPullPushView.js         |  61 -----------
>   www/config/SyncView.js                 | 134 ++++++++++++++++++++-----
>   www/datastore/DataStoreList.js         |   2 +-
>   www/datastore/Panel.js                 |   2 +-
>   10 files changed, 178 insertions(+), 110 deletions(-)
>   delete mode 100644 www/config/SyncPullPushView.js
> 



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel