From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Dominik Csapak" <d.csapak@proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox] sys: fs: set FD_CLOEXEC when creating temp files
Date: Fri, 29 Nov 2024 13:31:41 +0100 [thread overview]
Message-ID: <370c1808-5812-4c19-a084-3313243b3771@proxmox.com> (raw)
In-Reply-To: <ed920f89-2511-4fe0-8a6c-f92dd6561d8d@proxmox.com>
Am 29.11.24 um 11:21 schrieb Thomas Lamprecht:
> Am 29.11.24 um 09:02 schrieb Dominik Csapak:
>> the question for me is if it's ok to use since mkostemp is only a glibc extension (since 2.7) and we
>> may use that in proxmox-backup-client which we want to statically build ?
>> (not sure how that static compilation works with such a thing though...)
>
> FWIW, it's supported by MUSL:
>
> http://git.musl-libc.org/cgit/musl/tree/src/temp/mkostemp.c
And just to clarify, the rust libc crate supports different libc targets and
exposes mkostemp among others (all?) for both, the GNU libc a musl libc
targets.
So using that method might be indeed the best option for now and should not
hinder any static builds, as if not with glibc then we highly probably do
them with musl.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-29 12:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 14:54 Dominik Csapak
2024-11-29 7:57 ` Fabian Grünbichler
2024-11-29 8:02 ` Dominik Csapak
2024-11-29 8:14 ` Fabian Grünbichler
2024-11-29 10:21 ` Thomas Lamprecht
2024-11-29 12:31 ` Thomas Lamprecht [this message]
2024-11-29 13:12 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=370c1808-5812-4c19-a084-3313243b3771@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox