From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup 3/4] tools: file logger: use option struct to control behavior
Date: Fri, 16 Oct 2020 10:46:13 +0200 [thread overview]
Message-ID: <36df6a9b-2b64-241c-ba6e-6acb08ef9219@proxmox.com> (raw)
In-Reply-To: <1026037426.303.1602837870447@webmail.proxmox.com>
On 16.10.20 10:44, Dietmar Maurer wrote:
>
>> - let line = format!("{}: {}\n", rfc3339, msg);
>> + let line = if self.options.prefix_time {
>> + format!("{}: {}\n", rfc3339, msg)
>> + } else {
>> + format!("{}\n", msg)
>> + };
>
> This breaks the build (there is no prefix-time)
>
> error[E0609]: no field `prefix_time` on type `tools::file_logger::FileLogOptions`
> --> src/tools/file_logger.rs:67:36
> |
> 67 | let line = if self.options.prefix_time {
> | ^^^^^^^^^^^ unknown field
> |
> = note: available fields are: `to_stdout`
>
> error: aborting due to previous error
>
argh, sorry, to much git rebasing :(
I'll send a v2
next prev parent reply other threads:[~2020-10-16 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 15:49 [pbs-devel] Preperation patches for access/auth log Thomas Lamprecht
2020-10-15 15:49 ` [pbs-devel] [PATCH backup 1/4] server: rest: implement max URI path and query length request limits Thomas Lamprecht
2020-10-16 8:45 ` [pbs-devel] applied: " Dietmar Maurer
2020-10-15 15:49 ` [pbs-devel] [PATCH backup 2/4] server: rest: also log the query part of URL Thomas Lamprecht
2020-10-16 8:46 ` [pbs-devel] applied: " Dietmar Maurer
2020-10-15 15:49 ` [pbs-devel] [PATCH backup 3/4] tools: file logger: use option struct to control behavior Thomas Lamprecht
2020-10-16 8:44 ` Dietmar Maurer
2020-10-16 8:46 ` Thomas Lamprecht [this message]
2020-10-15 15:49 ` [pbs-devel] [PATCH backup 4/4] tools: file logger: allow more control over file creation and log format Thomas Lamprecht
2020-10-16 8:51 ` [pbs-devel] applied: " Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36df6a9b-2b64-241c-ba6e-6acb08ef9219@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox