public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
	"Proxmox Backup Server development discussion"
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/4] www: don't default to hourly sync job schedule
Date: Wed, 4 Nov 2020 18:03:59 +0100	[thread overview]
Message-ID: <36da0d46-e9d9-103b-6166-fbd977b6e84f@proxmox.com> (raw)
In-Reply-To: <1604497203.f21gwhaa55.astroid@nora.none>

On 04.11.20 14:46, Fabian Grünbichler wrote:
> On November 4, 2020 2:38 pm, Thomas Lamprecht wrote:
>> On 04.11.20 14:10, Fabian Grünbichler wrote:
>>> this breaks editing disabled sync jobs, and is also not consistent with
>>
>> just means that we should only set it onCreate..
> 
> also fine for me.
> 
>>> the backend defaults.
>>
>> which is? FWICT, there's no default in the backend - I want one here,
>> this can be easily edited and it's just better UX to avoid more decisions
>> which at this point may not be clear.
> 
> the backend's default is None/no schedule. for such simply values I 
> don't see much value in having a different default in the GUI, but I 
> don't care much either way.

A default for the backend would be a bit subtle and hard to change, if we'd like
to do so in the future. In the UI it's clearly presented to the user, they can
easily change it and we're pretty free to adapt it there if feedback shows that
would be better.

One should IMO not see the UI as plain "HTML form" like extension of an API, if it
would be that easy we could just auto generate it :)

> 
> for users that don't know much about sync jobs it might not be that 
> obvious how to have no schedule or even that that is an option when 
> creating a new one (you manually have to delete the value in the 
> picker/combobox).
> 

creating a new job without schedule seldom makes sense, I'd argue. Also, that it can
be temporarily be paused by deleting the schedule is subtle anyway, and IMO bad UX.
Not setting a default does not helps to suggest that is the case either, if we
want to make this clear, an explicit enable/disable checkbox which enables/disables
also the schedule field could be added.

But, an user also can just delete the job entry, if they just need to disable it and
cannot relate to the "clear schedule == disable", there's no relevant state full
information bound to a job. So, I do not see the need for it.


Again, to much words and pedantry for such a simple thing, sorry about that :-)





      parent reply	other threads:[~2020-11-04 17:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04 13:10 Fabian Grünbichler
2020-11-04 13:10 ` [pbs-devel] [PATCH proxmox-backup 2/4] types: extract DataStoreListItem Fabian Grünbichler
2020-11-04 13:10 ` [pbs-devel] [PATCH proxmox-backup 3/4] api: refactor remote client and add remote scan Fabian Grünbichler
2020-11-04 16:57   ` Thomas Lamprecht
2020-11-05  7:42     ` Fabian Grünbichler
2020-11-05  9:03       ` Thomas Lamprecht
2020-11-04 17:12   ` Thomas Lamprecht
2020-11-05  7:43     ` Fabian Grünbichler
2020-11-05  8:58       ` Thomas Lamprecht
2020-11-04 13:10 ` [pbs-devel] [PATCH proxmox-backup 4/4] www: add remote store selector Fabian Grünbichler
2020-11-04 13:42 ` [pbs-devel] [PATCH proxmox-backup 1/4] www: don't default to hourly sync job schedule Thomas Lamprecht
     [not found] ` <dce0d21f-20dc-5443-bbb0-6b6f5be73e43@proxmox.com>
     [not found]   ` <1604497203.f21gwhaa55.astroid@nora.none>
2020-11-04 17:03     ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36da0d46-e9d9-103b-6166-fbd977b6e84f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal