public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] applied: [RFC PATCH proxmox-backup 2/2] file-restore: dynamically increase memory of vm for zpools
Date: Mon, 7 Nov 2022 18:15:21 +0100	[thread overview]
Message-ID: <36968ac0-73c1-466a-e122-485a2598d14b@proxmox.com> (raw)
In-Reply-To: <20221107123538.i355vavyncl5edm7@casey.proxmox.com>

Am 07/11/2022 um 13:35 schrieb Wolfgang Bumiller:
> applied

meh, can we please get this opt-in any only enabled it for root@pam or for users
with some powerfull priv on / as talked as chosen approach to allow more memory the
last time this came up (off list IIRC)... I really do *not* want a memory DOS potential
increased by a lot just opening some file-restore tabs, this actually should get more
restrictions (for common "non powerfull" users), not less..

> 
> AFAICT if the kernel patch is not applied it'll simply have no effect
> anyway, so we shouldn't need any "hard dependency bumps" where
> otherweise things break?

if you actually want to enforce that the new behavior is there you need a dependency
bump.




  reply	other threads:[~2022-11-07 17:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31 11:39 [pbs-devel] [RFC PATCH backup-restore-image/proxmox-backup] improve file-restore " Dominik Csapak
2022-10-31 11:39 ` [pbs-devel] [RFC PATCH backup-restore-image 1/1] add kernel config options for memory hotplug Dominik Csapak
2022-11-07 12:48   ` [pbs-devel] applied: " Wolfgang Bumiller
2022-10-31 11:39 ` [pbs-devel] [PATCH proxmox-backup 1/2] file-restore: fix deprecated qemu parameters Dominik Csapak
2022-11-04 12:29   ` [pbs-devel] applied: " Wolfgang Bumiller
2022-10-31 11:39 ` [pbs-devel] [RFC PATCH proxmox-backup 2/2] file-restore: dynamically increase memory of vm for zpools Dominik Csapak
2022-11-07 12:35   ` [pbs-devel] applied: " Wolfgang Bumiller
2022-11-07 17:15     ` Thomas Lamprecht [this message]
2022-11-08  7:59       ` Dominik Csapak
2022-11-08  9:19         ` Thomas Lamprecht
2022-11-08 10:07           ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36968ac0-73c1-466a-e122-485a2598d14b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal