Re: [pbs-devel] applied: [PATCH proxmox-backup 3/5] ui: datastore content: add context menu to groups and snapshots

[Dominik Csapak <d.csapak@proxmox.com>]

On 11/28/23 16:27, Thomas Lamprecht wrote:
> Am 28/11/2023 um 10:44 schrieb Dominik Csapak:
>> and show the relevant actions. They will be forwarded to the controller,
>> so we can reuse that code without big refactoring them into another
>> class/place.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> sadly no keyboard navigation in there.. but i'm looking into it
>>
>>   www/datastore/Content.js | 114 +++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 114 insertions(+)
>>
>>
> 
> applied this one for now, thanks!
> 
> Albeit, I'm wondering if we should add the ID into the menu header, for
> snapshots that tends to be a bit large though...

yeah i tried that, but couldn't make it look ok and consistent, so i left it out.
If you have an idea how to format it (maybe "type \n id \n time" ?)
it should be relatively trivial to implement.

> 
> Oh, and fwiw, we could add a "Copy Text" for the cells where it makes
> sense (ID of group or snapshot, comment firt line, maybe date) so that
> one has it slightly easier if they found the wanted snapshot/group here
> and what to use that ID for, e.g., finding that in the PVE storage
> content UI, but no hard feelings, just as an idea.

yeah that could make sense, or maybe easier if we allow selecting the
text of the cells directly? that way the users can select copy themselves.
(we'd have to show the context menu depending on if text is selected or
not of course, but that should be doable without much issues)