Re: [pbs-devel] [PATCH proxmox{, -backup} 0/5] parallelize chunk reads in verification

[Christian Ebner <c.ebner@proxmox.com>]

On 11/5/25 4:51 PM, Nicolas Frey wrote:
> This patch series aims to expand on Dominik's series [0] written for
> pbs 3, parallelizing chunk reads in `VerifyWorker` using a seperate
> thread pool from the verification.
> 
> The number of threads was previously hard-coded, but is now
> configurable via the API and GUI with a new property called
> `worker-threads`, similarly to tape backups.
> 
> The number of `worker-threads` only controls the thread pool for
> reading, though if it makes sense to reuse this for the verification
> pool, it could be adjusted to do so too.
> 
> In my local tests I measured the following speed difference:
> verified a single snapshot with ~32 GiB (4x the RAM size) with 4 cores
> 
> 1 thread:    ~440MiB/s
> 2 threads:   ~780MiB/s
> 4 threads:   ~1140MiB/s
> 
> [0] https://lore.proxmox.com/pbs-devel/20250707132706.2854973-1-d.csapak@proxmox.com/#t

Thanks for the patches, nice work!

I will go trough and comment on individual patches, but one thing upfront:

Could you also include a concise description of what the additional 
parameter for the verification job config controlles to the docs? So we 
can point users directly to that.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel