Re: [pbs-devel] [PATCH proxmox-backup 0/2] Introduce bitflags for overwrite

[Christian Ebner <c.ebner@proxmox.com>]

Please ignore this one, I sent a rebased and refactored v2.

Cheers,
Chris

> On 07.06.2023 15:30 CEST Christian Ebner <c.ebner@proxmox.com> wrote:
> 
>  
> When restoring a pxar archive to a target containing preexisting data,
> the `overwrite` flag allows to force recreation of file payloads.
> However, the current implementation does not allow for symlinks or
> hardlinks to be recreated.
> 
> These patches introduce the logic to overwrite symlinks and hardlinks for
> archive entries, if a directory entry with matching name is already
> present on the filesystem. An existing entry is unlinked and the
> symlink/hardlink created.
> 
> In order to allow a more fine grained control over the overwrite
> behaviour, the current overwrite flag is refactored to set all bits of a
> newly introduced bitflag. Further, optional parameters for individual bits
> controlling the overwriting of files, symlinks and hardlinks are
> created.
> 
> Christian Ebner (2):
>   fix: #4761: unlink existing entries for hard/symlinks when overwrite
>   fix: #4761: introduce overwrite bitflags for fine grained overwrites
> 
>  pbs-client/src/catalog_shell.rs   |  9 +++-
>  pbs-client/src/pxar/extract.rs    | 82 ++++++++++++++++++++++++++-----
>  pbs-client/src/pxar/mod.rs        |  2 +-
>  proxmox-backup-client/src/main.rs | 28 ++++++++++-
>  pxar-bin/src/main.rs              | 32 +++++++++++-
>  5 files changed, 135 insertions(+), 18 deletions(-)
> 
> -- 
> 2.39.2