[pbs-devel] [PATCH proxmox-backup] api: notification: correctly enumerate known push-sync-jobs

[pbs-devel] [PATCH proxmox-backup] api: notification: correctly enumerate known push-sync-jobs

[Lukas Wagner]

The second parameter of list_config_sync_jobs determines the direction
(either push, pull, or both) of jobs that should be returned. Using a
value of 'None' makes the implementation fall back to the default, which
is 'pull'. This led to only pull-style jobs being returned from the
'matcher-field-values' endpoint.

This issue likely existed since the introduction of push-style jobs.

Fixes: https://forum.proxmox.com/threads/170987
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 src/api2/config/notifications/mod.rs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/api2/config/notifications/mod.rs b/src/api2/config/notifications/mod.rs
index f79fc78b7..40fe4dfaa 100644
--- a/src/api2/config/notifications/mod.rs
+++ b/src/api2/config/notifications/mod.rs
@@ -12,7 +12,7 @@ use crate::api2::admin::datastore::get_datastore_list;
 use pbs_api_types::PRIV_SYS_AUDIT;
 
 use crate::api2::admin::prune::list_prune_jobs;
-use crate::api2::admin::sync::list_config_sync_jobs;
+use crate::api2::admin::sync::{list_config_sync_jobs, ListSyncDirection};
 use crate::api2::admin::verify::list_verification_jobs;
 use crate::api2::config::media_pool::list_pools;
 use crate::api2::tape::backup::list_tape_backup_jobs;
@@ -156,7 +156,8 @@ pub fn get_values(
         });
     }
 
-    let sync_jobs = list_config_sync_jobs(None, None, param.clone(), rpcenv)?;
+    let sync_jobs =
+        list_config_sync_jobs(None, Some(ListSyncDirection::All), param.clone(), rpcenv)?;
     for job in sync_jobs {
         values.push(MatchableValue {
             field: "job-id".into(),
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup] api: notification: correctly enumerate known push-sync-jobs

[Christian Ebner]

Same issue persists with push sync jobs not being taken into account 
when removing a datastore. That is however unrelated to the 
notifications, will send a dedicated patch for that.

Consider this patch:

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup] api: notification: correctly enumerate known push-sync-jobs

[Thomas Lamprecht]

On Mon, 15 Dec 2025 14:27:33 +0100, Lukas Wagner wrote:
> The second parameter of list_config_sync_jobs determines the direction
> (either push, pull, or both) of jobs that should be returned. Using a
> value of 'None' makes the implementation fall back to the default, which
> is 'pull'. This led to only pull-style jobs being returned from the
> 'matcher-field-values' endpoint.
> 
> This issue likely existed since the introduction of push-style jobs.
> 
> [...]

Applied, thanks!

[1/1] api: notification: correctly enumerate known push-sync-jobs
      commit: 5a20c534acbdbaf25aabdfb1aad5a24e07f11f65


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel