[pbs-devel] [PATCH proxmox-backup] pbs2to3: fix #5600: expect any kernel 6.x version above 6.2.16

[pbs-devel] [PATCH proxmox-backup] pbs2to3: fix #5600: expect any kernel 6.x version above 6.2.16

[Daniel Kral]

Fixes a minor bug where `pbs2to3` shows an incorrect warning about an
incompatible kernel version, where newer kernel versions than 6.5.* were
marked as unexpected.

Signed-off-by: Daniel Kral <d.kral@proxmox.com>
---
 src/bin/pbs2to3.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/pbs2to3.rs b/src/bin/pbs2to3.rs
index 1f895abd..194a077e 100644
--- a/src/bin/pbs2to3.rs
+++ b/src/bin/pbs2to3.rs
@@ -130,7 +130,7 @@ impl Checker {
         self.output.log_info("Check running kernel version..")?;
         let (krunning, kinstalled) = if self.upgraded {
             (
-                Regex::new(r"^6\.(?:2\.(?:[2-9]\d+|1[6-8]|1\d\d+)|5)[^~]*$")?,
+                Regex::new(r"^6\.(?:2\.(?:[2-9]\d+|1[6-8]|1\d\d+)|([5-9]|\d{2,}))[^~]*$")?,
                 "proxmox-kernel-6.2",
             )
         } else {
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup] pbs2to3: fix #5600: expect any kernel 6.x version above 6.2.16

[Maximiliano Sandoval]

Daniel Kral <d.kral@proxmox.com> writes:

> Fixes a minor bug where `pbs2to3` shows an incorrect warning about an
> incompatible kernel version, where newer kernel versions than 6.5.* were
> marked as unexpected.
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>

I think this would benefit from a small #[test] where a few kernel
versions are tested.

-- 
Maximiliano


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup] pbs2to3: fix #5600: expect any kernel 6.x version above 6.2.16

[Fiona Ebner]

Am 23.08.24 um 16:37 schrieb Daniel Kral:
> Fixes a minor bug where `pbs2to3` shows an incorrect warning about an
> incompatible kernel version, where newer kernel versions than 6.5.* were
> marked as unexpected.
> 
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
>  src/bin/pbs2to3.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/bin/pbs2to3.rs b/src/bin/pbs2to3.rs
> index 1f895abd..194a077e 100644
> --- a/src/bin/pbs2to3.rs
> +++ b/src/bin/pbs2to3.rs
> @@ -130,7 +130,7 @@ impl Checker {
>          self.output.log_info("Check running kernel version..")?;
>          let (krunning, kinstalled) = if self.upgraded {
>              (
> -                Regex::new(r"^6\.(?:2\.(?:[2-9]\d+|1[6-8]|1\d\d+)|5)[^~]*$")?,
> +                Regex::new(r"^6\.(?:2\.(?:[2-9]\d+|1[6-8]|1\d\d+)|([5-9]|\d{2,}))[^~]*$")?,
>                  "proxmox-kernel-6.2",
>              )
>          } else {

In PVE and PMG we allow arbitrary newer -pve kernels for
future-proofing, it would be nice to do the same here too:

https://git.proxmox.com/?p=pve-manager.git;a=commit;h=fb59038a8b110b0b0b438ec035fd41dd9d591232

https://git.proxmox.com/?p=pmg-api.git;a=commit;h=9d67a9af218b73027822c9c4665b88e6662e7ef7


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel