Re: [pbs-devel] [PATCH proxmox-backup 17/23] ui: add datastore status mask for unplugged removable datastores

[Lukas Wagner <l.wagner@proxmox.com>]

On 9/15/23 08:54, Hannes Laimer wrote:
> diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js
> index dfff6e7f..d80c4a08 100644
> --- a/www/datastore/Summary.js
> +++ b/www/datastore/Summary.js
> @@ -61,16 +61,20 @@ Ext.define('PBS.DataStoreInfo', {
>   		Proxmox.Utils.API2Request({
>   		    url: `/config/datastore/${me.view.datastore}`,
>   		    success: function(response) {
> -			const config = response.result.data;
> -			if (config['maintenance-mode']) {
> -			    const [_type, msg] = PBS.Utils.parseMaintenanceMode(config['maintenance-mode']);
> -			    me.view.el.mask(
> -				`${gettext('Datastore is in maintenance mode')}${msg ? ': ' + msg : ''}`,
> -				'fa pbs-maintenance-mask',
> -			    );
> -			} else {
> +			const maintenanceString = response.result.data['maintenance-mode'];
> +			if (!maintenanceString) {
>   			    me.view.el.mask(gettext('Datastore is not available'));
> +			    return;
>   			}
> +
> +			const [type, msg] = PBS.Utils.parseMaintenanceMode(maintenanceString);
> +			const isUnplugged = type === 'unplugged';
> +			const maskMessage = isUnplugged
> +			    ? gettext('Datastore is unplugged')
> +			    : `${gettext('Datastore is in maintenance mode')}${msg ? ': ' + msg : ''}`;

I know this expression existed before, but maybe use the opportunity to 
make it a bit more readable? It's a bit hard to parse for my brain :)

-- 
- Lukas