public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/4] remote edit: error message ideas
Date: Tue, 26 Jan 2021 11:34:54 +0100	[thread overview]
Message-ID: <31f19138-bb58-1854-35f9-ef3023bb2c74@proxmox.com> (raw)
In-Reply-To: <20210119110915.18864-1-d.jaeger@proxmox.com>

ok after taking a look at it, there are some problems

while i'd find the asterisk ok, the combination of patches
here do not really work together well.

when we have the error icon, we'd not need the asterisk,
since they both show the error or were they not intended
to be applied together?

also, the generic tooltip does always show on the whole
element for me, so with either the asterisk or the
icon, i still get multiple tooltips over one another

another problem is with the detection of the 'required'
error. while this may work on english, extjs
errors are also translated, though i noticed we do
not do this yet for pbs (for pve we do)
so filtering by 'required' cannot work for other languages

and last but not least:
would it not be possible to show the tooltip just on the
label?
e.g.:

---
fieldLabel: `<div qtip="sometext">${gettext('labeltext')}</div>'
---

a little bit less intuitive, but should not create overlapping
tooltips

another alternative would be to add a displayfield below the
field with an explanation?

or simply add a screenshot with a list of fields to the documentation?

On 1/19/21 12:09 PM, Dominic Jäger wrote:
> Already talked about the first patch for #3058 with Thomas. Hope that this is
> now acceptable.
> 
> The rest is rather to show what we could maybe do and how much code that would
> require.
> 
> Dominic Jäger (4):
>    ui: remote edit: Add tooltips
>    ui: remote edit: Add asterisks
>    ui: remote edit: Error as symbol to the right
>    ui: remote edit: Change asterisk color
> 
>   www/Utils.js             | 15 +++++++++++++++
>   www/window/RemoteEdit.js | 35 +++++++++++++++++++++++++++++++++++
>   2 files changed, 50 insertions(+)
> 




  parent reply	other threads:[~2021-01-26 10:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 11:09 Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 1/4] ui: remote edit: Add tooltips Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 2/4] ui: remote edit: Add asterisks Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 3/4] ui: remote edit: Error as symbol to the right Dominic Jäger
2021-01-19 11:09 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: remote edit: Change asterisk color Dominic Jäger
2021-01-26 10:34 ` Dominik Csapak [this message]
2021-01-27 10:55   ` [pbs-devel] [PATCH proxmox-backup 0/4] remote edit: error message ideas Dominic Jäger
2021-01-27 13:57     ` Dominik Csapak
2021-01-27 14:39       ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31f19138-bb58-1854-35f9-ef3023bb2c74@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal