From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Fiona Ebner <f.ebner@proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH] log: fallback to stderr if syslog not available
Date: Thu, 12 Sep 2024 11:38:54 +0200 (CEST) [thread overview]
Message-ID: <317943379.28985.1726133934722@webmail.proxmox.com> (raw)
In-Reply-To: <e901351f-5b98-4946-8c82-f10c257bb1bd@proxmox.com>
also got filed as https://bugzilla.proxmox.com/show_bug.cgi?id=5712, might be nice to fold that into the commit title when applied..
> Fiona Ebner <f.ebner@proxmox.com> hat am 12.09.2024 11:29 CEST geschrieben:
> Am 10.09.24 um 15:03 schrieb Gabriel Goller:
> > Don't panic when the syslog is not available - which happens commonly in
> > containers and sbuild environments (chroot and unshare) - instead
> > fallback to stderr.
> >
> > Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> > ---
> >
> > Note: this fixes `make sbuild` for pve-storage.
> > Disclaimer: haven't quite figured out why tbh, I don't see where the
> > verify_api function calls proxmox-backup-api or proxmox-backup-proxy.
> >
>
> It's also used by libpve-rs and I can confirm "injecting" (done using
> sbuild options --starting-build-commands and --pre-build-commands) a
> package of libpve-rs-perl that incorporates your proxmox-log change
> makes building pve-storage and pve-container work again :)
just for the record or to save you some trouble the next time - injecting a changed package into the build env can simply be done via --extra-package (either pointed at the .deb file, or at a dir containing .deb files to be injected). --extra-repository also works, but requires exposing them as repository..
> Tested-by: Fiona Ebner <f.ebner@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-09-12 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 13:03 Gabriel Goller
2024-09-12 9:29 ` Fiona Ebner
2024-09-12 9:38 ` Fabian Grünbichler [this message]
2024-09-12 9:50 ` Fiona Ebner
2024-09-16 13:12 ` [pbs-devel] applied: " Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=317943379.28985.1726133934722@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox