Re: [pbs-devel] [PATCH proxmox-backup v8 02/23] pbs-api-types: add backing-device to DataStoreConfig

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v8 02/23] pbs-api-types: add backing-device to DataStoreConfig
Date: Mon, 22 Apr 2024 09:12:49 +0200	[thread overview]
Message-ID: <310fe4e2-b917-4771-b1ea-1c7f1bcb6128@proxmox.com> (raw)
In-Reply-To: <20240419155606.112010-3-h.laimer@proxmox.com>

Am 19/04/2024 um 17:55 schrieb Hannes Laimer:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  pbs-api-types/src/datastore.rs | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
> index 9fe45bc0..469b2ba4 100644
> --- a/pbs-api-types/src/datastore.rs
> +++ b/pbs-api-types/src/datastore.rs
> @@ -160,6 +160,8 @@ pub const PRUNE_SCHEMA_KEEP_YEARLY: Schema =
>          .minimum(1)
>          .schema();
>  
> +pub const REMOVABLE_DATASTORE_MOUNT_DIR: &str = "/mnt/removable_datastore";

please use kebab-case: removable-datastore 

It would be great to write some reasoning for using a different mount
path for removable datastore, as IMO that's really not something
obvious..

In fact, why do we require having that separate?

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel