From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH proxmox-backup] data_blob: add TODO comment for zstd api
Date: Fri, 30 Aug 2024 11:00:25 +0200 [thread overview]
Message-ID: <2xgl6gaqg6hqo56kiyjukzqvhvwizm2uk4qvwrir3zqzsacmbw@a6mxr6ryb66p> (raw)
In-Reply-To: <20240808081825.325983-1-d.csapak@proxmox.com>
applied, thanks
On Thu, Aug 08, 2024 at 10:18:25AM GMT, Dominik Csapak wrote:
> we currently use the behavior of zstd that is not part of the public
> api, so this is at risk to be changed without notice.
>
> There is a public api that we could use, but it's only available
> with zstd_sys >= 2.0.9, which at this time, is not yet packaged for/by
> us.
>
> Add a comment that we can use the public api for this when the
> new version of the crate gets available.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> after looking whom to report that the api would benefit from better
> error handling, i noticed that zstd_sys already has what we need, but
> only in a newer version, which we currently don't package
>
> pbs-datastore/src/data_blob.rs | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/pbs-datastore/src/data_blob.rs b/pbs-datastore/src/data_blob.rs
> index fd84f4be..0fb4d44c 100644
> --- a/pbs-datastore/src/data_blob.rs
> +++ b/pbs-datastore/src/data_blob.rs
> @@ -556,6 +556,8 @@ impl<'a, 'b> DataChunkBuilder<'a, 'b> {
> ///
> /// There is a test below to ensure we catch any change in the interface or internal value.
> fn zstd_error_is_target_too_small(err: usize) -> bool {
> + // TODO: when zstd_sys >= 2.0.9 is available, we can use
> + // ZSTD_getErrorCode and the enum to use the public zstd API
> let (real_code, _) = 0usize.overflowing_sub(err);
> // see ZSTD_ErrorCode in https://github.com/facebook/zstd/blob/dev/lib/zstd_errors.h
> real_code == 70 // ZSTD_error_dstSize_tooSmall
> --
> 2.39.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-08-30 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 8:18 [pbs-devel] " Dominik Csapak
2024-08-30 9:00 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2xgl6gaqg6hqo56kiyjukzqvhvwizm2uk4qvwrir3zqzsacmbw@a6mxr6ryb66p \
--to=w.bumiller@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox