Re: [PATCH proxmox-backup v5 1/9] ui: show empty groups

[Dominik Csapak <d.csapak@proxmox.com>]

Hi,

high level comments:

the verify button is disabled for empty groups (good!) but the
prune button is not, better to disable that too

also the 'verify state' column shows 'all ok', while technically
not wrong, I think it would be better to don't render anything
at all there if the groups does not have any snapshots,
but this could be done as a follow up / extra patch.

one comment inline

On 3/19/26 5:12 PM, Hannes Laimer wrote:
[snip]
> @@ -232,6 +241,29 @@ Ext.define('PBS.DataStoreContent', {
>   
>               let groups = this.getRecordGroups(records);
>   
> +            for (const item of groupList) {
> +                let btype = item['backup-type'];
> +                let group = btype + '/' + item['backup-id'];
> +                if (groups[group] !== undefined) {
> +                    continue;
> +                }
> +                let cls = PBS.Utils.get_type_icon_cls(btype);
> +                if (cls === '') {
> +                    continue;
> +                }
> +                groups[group] = {
> +                    text: group,
> +                    leaf: true,
> +                    iconCls: 'fa ' + cls,
> +                    expanded: false,
> +                    backup_type: btype,
> +                    backup_id: item['backup-id'],
> +                    comment: item.comment,
> +                    owner: item.owner,
> +                    children: [],
> +                };
> +            }
> +

this hunk is more or less a 1:1 copy of 'getRecordGroups'
(minus the comment/owner column)

I think we should reuse that (maybe with a flag to set the comment/owner 
when we know it's from the group, or factor out the inner part of the 
loop and add the comment/owner manually after calling that)

>               let selected;
>               let expanded = {};
>   
> @@ -399,7 +431,7 @@ Ext.define('PBS.DataStoreContent', {
>                   );
>               }
>   
> -            this.updateGroupNotes(view);
> +            this.updateGroupNotes(view, groupList);
>   
>               if (selected !== undefined) {
>                   let selection = view.getRootNode().findChildBy(
> @@ -985,7 +1017,7 @@ Ext.define('PBS.DataStoreContent', {
>               flex: 1,
>               renderer: (v, meta, record) => {
>                   let data = record.data;
> -                if (!data || data.leaf || data.root) {
> +                if (!data || (data.leaf && data.ty !== 'group') || data.root) {
>                       return '';
>                   }
>   
> @@ -1029,7 +1061,7 @@ Ext.define('PBS.DataStoreContent', {
>                   },
>                   dblclick: function (tree, el, row, col, ev, rec) {
>                       let data = rec.data || {};
> -                    if (data.leaf || data.root) {
> +                    if ((data.leaf && data.ty !== 'group') || data.root) {
>                           return;
>                       }
>                       let view = tree.up();