From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 1/1] fix #3828: proxmox_backup_debug: Introduce `diff archive` subcommand.
Date: Wed, 23 Nov 2022 16:46:18 +0100 [thread overview]
Message-ID: <2e50df5c-ef57-cbd1-e59e-403cf09f3008@proxmox.com> (raw)
In-Reply-To: <20221028100143.9035-2-l.wagner@proxmox.com>
Am 28/10/2022 um 12:01 schrieb Lukas Wagner:
> This new subcommand compares a pxar archive in two different
> snapshots and prints a list of added/modified/deleted file
> entries.
for future patches please avoid the use of folder or generally file names in
the subject, "proxmox backup" is also a bit redundant if it's in the proxmox-backup
repo already anyway. Here I'd have favored:
fix #3828: debug cli: Introduce `diff archive` subcommand
or maybe even:
fix #3828: debug cli: add `diff archive` to compare pxar from snapshots
really no biggie, but I'm calling these things out because I frequently
do releases and assemble changelogs and need to churn through dozens of
commits in a timely manner to extract the for user relevant stuff, and
often it's great when I just grasp the whole change from the subject
only, even when it was a month ago or I did not followed its development
at all, and maybe even can copy it 1:1 to the debian/changelog.
prev parent reply other threads:[~2022-11-23 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 10:01 [pbs-devel] [PATCH v2 proxmox-backup 0/1] " Lukas Wagner
2022-10-28 10:01 ` [pbs-devel] [PATCH v2 proxmox-backup 1/1] " Lukas Wagner
2022-11-23 10:26 ` [pbs-devel] applied: " w.bumiller
2022-11-23 15:46 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e50df5c-ef57-cbd1-e59e-403cf09f3008@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox