public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] server/worker_task: simplify task log writing
Date: Thu, 29 Oct 2020 13:11:26 +0100	[thread overview]
Message-ID: <2e163113-53d4-5c93-95f8-8b84fddd4400@proxmox.com> (raw)
In-Reply-To: <20201029095013.4885-1-d.csapak@proxmox.com>

On 29.10.20 10:50, Dominik Csapak wrote:
> instead of prerotating 1000 tasks
> (which resulted in 2 writes each time an active worker was finished)
> simply append finished tasks to the archive (which will be rotated)
> 
> page cache should be good enough so that we can get the task logs fast
> 
> since existing installations might have an 'index' file, we
> still have to read tasks from there, but only if it exists
> 
> this simplifies the TaskListInfoIterator a good amount
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> we now write all finished tasks into the archive, as soon as
> any code tries to iterate over any finished task
> 
> this way we can remove most of the index handling code, besides
> that tiny bit of compatibility that we can drop with 1.x
> 
>  src/server/worker_task.rs | 91 +++++++++++++--------------------------
>  1 file changed, 29 insertions(+), 62 deletions(-)
> 
>

applied, thanks!




      reply	other threads:[~2020-10-29 12:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29  9:50 [pbs-devel] " Dominik Csapak
2020-10-29 12:11 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e163113-53d4-5c93-95f8-8b84fddd4400@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal