From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup 3/5] ui: datastore content: add context menu to groups and snapshots
Date: Tue, 28 Nov 2023 16:27:42 +0100 [thread overview]
Message-ID: <2dfe28d8-8f26-496d-9da8-9f3bcb99b15c@proxmox.com> (raw)
In-Reply-To: <20231128094402.38115-4-d.csapak@proxmox.com>
Am 28/11/2023 um 10:44 schrieb Dominik Csapak:
> and show the relevant actions. They will be forwarded to the controller,
> so we can reuse that code without big refactoring them into another
> class/place.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> sadly no keyboard navigation in there.. but i'm looking into it
>
> www/datastore/Content.js | 114 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 114 insertions(+)
>
>
applied this one for now, thanks!
Albeit, I'm wondering if we should add the ID into the menu header, for
snapshots that tends to be a bit large though...
Oh, and fwiw, we could add a "Copy Text" for the cells where it makes
sense (ID of group or snapshot, comment firt line, maybe date) so that
one has it slightly easier if they found the wanted snapshot/group here
and what to use that ID for, e.g., finding that in the PVE storage
content UI, but no hard feelings, just as an idea.
next prev parent reply other threads:[~2023-11-28 15:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 9:43 [pbs-devel] [PATCH proxmox-backup 0/5] add context menu to datastore content Dominik Csapak
2023-11-28 9:43 ` [pbs-devel] [PATCH proxmox-backup 1/5] api-types: add an UploadStatistic api type Dominik Csapak
2023-11-28 9:43 ` [pbs-devel] [PATCH proxmox-backup 2/5] api: datastore admin: add 'snapshot-information' api call Dominik Csapak
2023-11-28 9:44 ` [pbs-devel] [PATCH proxmox-backup 3/5] ui: datastore content: add context menu to groups and snapshots Dominik Csapak
2023-11-28 15:27 ` Thomas Lamprecht [this message]
2023-11-29 7:35 ` [pbs-devel] applied: " Dominik Csapak
2023-11-29 7:47 ` Thomas Lamprecht
2023-11-28 9:44 ` [pbs-devel] [PATCH proxmox-backup 4/5] ui: datastore content: add snapshot information to context menu Dominik Csapak
2023-11-28 9:44 ` [pbs-devel] [PATCH proxmox-backup 5/5] ui: datastore content: add 'more actions' menu to actions Dominik Csapak
2023-11-28 11:32 ` [pbs-devel] [PATCH proxmox-backup 0/5] add context menu to datastore content Fabian Grünbichler
2023-11-28 12:48 ` Philipp Hufnagl
2023-11-28 13:41 ` Max Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dfe28d8-8f26-496d-9da8-9f3bcb99b15c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox