Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: increase tapestore interval

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 10.03.21 10:10, Dominik Csapak wrote:
> from 2 to 60 seconds. To retain the response time of the gui
> when adding/editing/removing, trigger a manual reload on these actions
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

Please add my Suggested-by or Reported-by tags for reference the next time,
thanks!

> ---
>  www/NavigationTree.js     | 11 ++++++++++-
>  www/tape/ChangerConfig.js |  6 ++++++
>  www/tape/DriveConfig.js   |  6 ++++++
>  3 files changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/www/NavigationTree.js b/www/NavigationTree.js
> index 4bdfbc66..6d288f09 100644
> --- a/www/NavigationTree.js
> +++ b/www/NavigationTree.js
> @@ -122,7 +122,7 @@ Ext.define('PBS.view.main.NavigationTree', {
>  		if (view.tapestore === undefined) {
>  		    view.tapestore = Ext.create('Proxmox.data.UpdateStore', {
>  			autoStart: true,
> -			interval: 2 * 1000,
> +			interval: 60 * 1000,
>  			storeid: 'pbs-tape-drive-list',
>  			model: 'pbs-tape-drive-list',
>  		    });
> @@ -269,6 +269,15 @@ Ext.define('PBS.view.main.NavigationTree', {
>  	},
>      },
>  
> +    reloadTapeStore: function() {
> +	let me = this;
> +	if (!PBS.enableTapeUI) {
> +	    return;
> +	}
> +
> +	me.tapestore.load();
> +    },
> +
>      select: function(path, silent) {
>  	var me = this;
>  	if (me.rstore.isLoaded() && (!PBS.enableTapeUI || me.tapestore.isLoaded())) {
> diff --git a/www/tape/ChangerConfig.js b/www/tape/ChangerConfig.js
> index 1646ddef..1c048b23 100644
> --- a/www/tape/ChangerConfig.js
> +++ b/www/tape/ChangerConfig.js
> @@ -11,6 +11,11 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
>      controller: {
>  	xclass: 'Ext.app.ViewController',
>  
> +	reloadTapeStore: function() {
> +	    let navtree = Ext.ComponentQuery.query('navigationtree')[0];
> +	    navtree.reloadTapeStore();
> +	},
> +
>  	onAdd: function() {
>  	    let me = this;
>  	    Ext.create('PBS.TapeManagement.ChangerEditWindow', {
> @@ -40,6 +45,7 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
>  
>  	reload: function() {
>  	    this.getView().getStore().rstore.load();
> +	    this.reloadTapeStore();
>  	},
>  
>  	stopStore: function() {
> diff --git a/www/tape/DriveConfig.js b/www/tape/DriveConfig.js
> index 763f8e55..40d4b2a9 100644
> --- a/www/tape/DriveConfig.js
> +++ b/www/tape/DriveConfig.js
> @@ -19,6 +19,11 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
>      controller: {
>  	xclass: 'Ext.app.ViewController',
>  
> +	reloadTapeStore: function() {
> +	    let navtree = Ext.ComponentQuery.query('navigationtree')[0];
> +	    navtree.reloadTapeStore();
> +	},
> +
>  	onAdd: function() {
>  	    let me = this;
>  	    Ext.create('PBS.TapeManagement.DriveEditWindow', {
> @@ -57,6 +62,7 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
>  
>  	reload: function() {
>  	    this.getView().getStore().rstore.load();
> +	    this.reloadTapeStore();
>  	},
>  
>  	stopStore: function() {
>