public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 0/9] tape: improve restore ux
Date: Wed, 26 May 2021 19:16:03 +0200	[thread overview]
Message-ID: <2d681e81-286c-11e4-1c3d-914e67bd8eb0@proxmox.com> (raw)
In-Reply-To: <20210526134811.333-1-d.csapak@proxmox.com>

On 26.05.21 15:48, Dominik Csapak wrote:
> by
> * adding a 'generic' restore button that is very obvious
>   (in contrast to only the icon)
>   this makes it necessary to change the restore window so that
>   we can select the media-set there
> * also allowing datastores to be 'inline restored'
> * expanding the inital media-set list
> * renaming the 'action' column to 'restore' to make it more obvious
> * using the 'proper' backend code path for when the user selected
>   only 'whole' datastores
> * fixing some small bugs
> 

With expanding the pools and renaming the action column to the single action
it provides, namely "Restore" would have been already enough to defuse any
confusion about where to trigger a restore. Any how, it is definitively more
prominent this way, so I applied it with some small changes:

* set icones in the tbar button, matching with other uses
* always show the snapshot grid in the wizard to avoid that much empty space

And rather independent of your series: add a bit more context to the tooltip
of the restore action button.

The "Restore from Tape" docs section could do with some expansion and maybe even
a screenshot of the wizard now, then we could set the onlineHelp reference
in the wizard to - maybe we could then also explain there that restoring a whole
set is possibly cheaper to do than restoring a partial selection of snapshots.

thanks!




      parent reply	other threads:[~2021-05-26 17:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 13:48 [pbs-devel] " Dominik Csapak
2021-05-26 13:48 ` [pbs-devel] [PATCH proxmox-backup 1/9] ui: tape/BackupOverview: expand pools by default Dominik Csapak
2021-05-26 13:48 ` [pbs-devel] [PATCH proxmox-backup 2/9] api2/tape: add api call to list media sets Dominik Csapak
2021-05-26 13:48 ` [pbs-devel] [PATCH proxmox-backup 3/9] ui: tape/BackupOverview: rename action column to restore Dominik Csapak
2021-05-26 13:48 ` [pbs-devel] [PATCH proxmox-backup 4/9] ui: tape: add MediaSetSelector Dominik Csapak
2021-05-26 13:48 ` [pbs-devel] [PATCH proxmox-backup 5/9] ui: tape/TapeRestore: " Dominik Csapak
2021-05-26 13:48 ` [pbs-devel] [PATCH proxmox-backup 6/9] ui: tape/BackupOverview: add generic 'Restore' button Dominik Csapak
2021-05-26 13:48 ` [pbs-devel] [PATCH proxmox-backup 7/9] ui: tape/TapeRestore: don't send snapshotlist when restoring whole datastores Dominik Csapak
2021-05-26 13:48 ` [pbs-devel] [PATCH proxmox-backup 8/9] ui: tape/TapeRestore: allow preselecting a datastore Dominik Csapak
2021-05-26 13:48 ` [pbs-devel] [PATCH proxmox-backup 9/9] ui: tape/TapeRestore: fix some properties Dominik Csapak
2021-05-26 17:16 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d681e81-286c-11e4-1c3d-914e67bd8eb0@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal