Re: [PATCH proxmox-backup v5 7/9] ui: add move group action

[Dominik Csapak <d.csapak@proxmox.com>]

code looks good to me, but please add more information in the commit 
message.

On 3/19/26 5:13 PM, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>   www/Makefile             |  1 +
>   www/datastore/Content.js | 47 +++++++++++++++++++++++++++++++++
>   www/window/GroupMove.js  | 56 ++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 104 insertions(+)
>   create mode 100644 www/window/GroupMove.js
> 
> diff --git a/www/Makefile b/www/Makefile
> index 9ebf0445..7745d9f4 100644
> --- a/www/Makefile
> +++ b/www/Makefile
> @@ -76,6 +76,7 @@ JSSRC=							\
>   	config/PruneAndGC.js				\
>   	window/ACLEdit.js				\
>   	window/BackupGroupChangeOwner.js		\
> +	window/GroupMove.js				\
>   	window/CreateDirectory.js			\
>   	window/DataStoreEdit.js				\
>   	window/NamespaceEdit.js				\
> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
> index 981acdc7..b56cc4ac 100644
> --- a/www/datastore/Content.js
> +++ b/www/datastore/Content.js
> @@ -667,6 +667,27 @@ Ext.define('PBS.DataStoreContent', {
>               });
>           },
>   
> +        moveGroup: function (data) {
> +            let me = this;
> +            let view = me.getView();
> +            let group = `${data.backup_type}/${data.backup_id}`;
> +            Ext.create('PBS.window.GroupMove', {
> +                datastore: view.datastore,
> +                namespace: view.namespace,
> +                backupType: data.backup_type,
> +                backupId: data.backup_id,
> +                group,
> +                taskDone: () => me.reload(),
> +            }).show();
> +        },
> +
> +        onMove: function (table, rI, cI, item, e, { data }) {
> +            let me = this;
> +            if (data.ty === 'group') {
> +                me.moveGroup(data);
> +            }
> +        },
> +
>           forgetGroup: function (data) {
>               let me = this;
>               let view = me.getView();
> @@ -971,6 +992,7 @@ Ext.define('PBS.DataStoreContent', {
>                       onVerify: createControllerCallback('onVerify'),
>                       onChangeOwner: createControllerCallback('onChangeOwner'),
>                       onPrune: createControllerCallback('onPrune'),
> +                    onMove: createControllerCallback('onMove'),
>                       onForget: createControllerCallback('onForget'),
>                   });
>               } else if (record.data.ty === 'dir') {
> @@ -1085,6 +1107,20 @@ Ext.define('PBS.DataStoreContent', {
>                               : 'pmx-hidden',
>                       isActionDisabled: (v, r, c, i, rec) => !!rec.data.leaf,
>                   },
> +                {
> +                    handler: 'onMove',
> +                    getTip: (v, m, { data }) => {
> +                        if (data.ty === 'group') {
> +                            return Ext.String.format(gettext("Move group '{0}'"), v);
> +                        }
> +                        return '';
> +                    },
> +                    getClass: (v, m, { data }) => {
> +                        if (data.ty === 'group') { return 'fa fa-arrows'; }
> +                        return 'pmx-hidden';
> +                    },
> +                    isActionDisabled: (v, r, c, i, { data }) => false,
> +                },
>                   {
>                       handler: 'onChangeOwner',
>                       getClass: (v, m, { data }) =>
> @@ -1437,6 +1473,7 @@ Ext.define('PBS.datastore.GroupCmdMenu', {
>       onVerify: undefined,
>       onChangeOwner: undefined,
>       onPrune: undefined,
> +    onMove: undefined,
>       onForget: undefined,
>   
>       items: [
> @@ -1460,6 +1497,16 @@ Ext.define('PBS.datastore.GroupCmdMenu', {
>                   hidden: '{!onVerify}',
>               },
>           },
> +        {
> +            text: gettext('Move'),
> +            iconCls: 'fa fa-arrows',
> +            handler: function () {
> +                this.up('menu').onMove();
> +            },
> +            cbind: {
> +                hidden: '{!onMove}',
> +            },
> +        },
>           {
>               text: gettext('Change owner'),
>               iconCls: 'fa fa-user',
> diff --git a/www/window/GroupMove.js b/www/window/GroupMove.js
> new file mode 100644
> index 00000000..f663c606
> --- /dev/null
> +++ b/www/window/GroupMove.js
> @@ -0,0 +1,56 @@
> +Ext.define('PBS.window.GroupMove', {
> +    extend: 'Proxmox.window.Edit',
> +    alias: 'widget.pbsGroupMove',
> +    mixins: ['Proxmox.Mixin.CBind'],
> +
> +    onlineHelp: 'storage-namespaces',
> +
> +    isCreate: true,
> +    submitText: gettext('Move'),
> +    showTaskViewer: true,
> +
> +    cbind: {
> +        url: '/api2/extjs/admin/datastore/{datastore}/groups',
> +        title: (get) => Ext.String.format(gettext("Move Backup Group '{0}'"), get('group')),
> +    },
> +    method: 'PUT',
> +
> +    width: 400,
> +    fieldDefaults: {
> +        labelWidth: 120,
> +    },
> +
> +    items: {
> +        xtype: 'inputpanel',
> +        onGetValues: function (values) {
> +            let win = this.up('window');
> +            let result = {
> +                'backup-type': win.backupType,
> +                'backup-id': win.backupId,
> +                'new-ns': values['new-ns'] || '',
> +            };
> +            if (win.namespace && win.namespace !== '') {
> +                result.ns = win.namespace;
> +            }
> +            return result;
> +        },
> +        items: [
> +            {
> +                xtype: 'displayfield',
> +                fieldLabel: gettext('Group'),
> +                cbind: {
> +                    value: '{group}',
> +                },
> +            },
> +            {
> +                xtype: 'pbsNamespaceSelector',
> +                name: 'new-ns',
> +                fieldLabel: gettext('Target Namespace'),
> +                allowBlank: true,
> +                cbind: {
> +                    datastore: '{datastore}',
> +                },
> +            },
> +        ],
> +    },
> +});