From: Christian Ebner <c.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup v2 0/4] fix local marker cleanup for unreferenced, s3 only chunks
Date: Mon, 24 Nov 2025 13:51:29 +0100 [thread overview]
Message-ID: <2b637884-f6bd-434d-be00-fa4e9d9e2dcb@proxmox.com> (raw)
In-Reply-To: <176398699637.1851069.5128680534714572156.b4-ty@proxmox.com>
On 11/24/25 1:27 PM, Thomas Lamprecht wrote:
> On Mon, 24 Nov 2025 10:40:14 +0100, Christian Ebner wrote:
>> These patches fix an issue with garbage collection on S3 backends for an
>> edge case where the local chunk marker is missing and the chunk not
>> being referenced anymore by any index file. In that case garbage
>> collection failed when trying to remove the missing marker from the
>> local datastore cache.
>>
>> Fix this by adapting the phase 2 logic such that the atime is now
>> optional, skipping over the chunk sweep logic if not set and adding the
>> chunk directly for deletion.
>>
>> [...]
>
> Applied, thanks!
>
> While I applied the last patch already as the intentions behind it are
> worthwhile to already have, it's IMO not ideal and the function here is already
> quite crowded. Maybe creating a local wrapper struc/type around the delete Vec
> and age variables and implementing this logic on that struct would be nicer?
Yes, bundling all the logic regarding the delete list, including
creation and age checks, ecc. into a dedicated struct with its helpers
should help de-clutter this a bit. Will have a go at that, thanks!
> In any case, really not important for now, in fact, I probably won't even
> consider applying such patches this week.
>
> [1/4] GC: s3: fix local marker cleanup for unreferenced, s3 only chunks
> commit: e22be89d6d3f8113fc28a47e08600c759917f43d
> [2/4] chunk store: fix and expand the clear_chunk_expected_mark() docstring
> commit: d8499811f3cb338f02ccce1beeabd81c57fc129c
> [3/4] chunk store: clarify chunk marker helper creates marker if missing
> commit: bf279c52b5b8dc82093ad26cdf35ddf8b1b68fe1
> [4/4] datastore: refactor common delete list logic into closure
> commit: ed2ae6d3fbbeb19a19a57e9ed7d6ed7e59c22ba0
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-11-24 12:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 9:40 [pbs-devel] " Christian Ebner
2025-11-24 9:40 ` [pbs-devel] [PATCH proxmox-backup v2 1/4] GC: s3: " Christian Ebner
2025-11-24 9:40 ` [pbs-devel] [PATCH proxmox-backup v2 2/4] chunk store: fix and expand the clear_chunk_expected_mark() docstring Christian Ebner
2025-11-24 9:40 ` [pbs-devel] [PATCH proxmox-backup v2 3/4] chunk store: clarify chunk marker helper creates marker if missing Christian Ebner
2025-11-24 9:40 ` [pbs-devel] [PATCH proxmox-backup v2 4/4] datastore: refactor common delete list logic into closure Christian Ebner
2025-11-24 12:23 ` [pbs-devel] applied: [PATCH proxmox-backup v2 0/4] fix local marker cleanup for unreferenced, s3 only chunks Thomas Lamprecht
2025-11-24 12:51 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b637884-f6bd-434d-be00-fa4e9d9e2dcb@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox