From: Gabriel Goller <g.goller@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH v4 proxmox-backup 2/3] node: status: added bootmode
Date: Mon, 27 Nov 2023 14:28:14 +0100 [thread overview]
Message-ID: <2b073619-730b-4e39-affc-45cbc624ef7c@proxmox.com> (raw)
In-Reply-To: <qzqvjhqcakjbfsh3hns57tqngesm3htjefwowb7afoxozxvl25@zmdhioinjdc6>
Thanks for the review!
On 11/27/23 14:10, Wolfgang Bumiller wrote:
> On Mon, Nov 27, 2023 at 11:52:37AM +0100, Gabriel Goller wrote:
>> +
>> +#[api]
>> +#[derive(Serialize, Deserialize, Default)]
> And Clone + Copy
Agree
>> +#[serde(rename_all = "kebab-case")]
>> +/// The possible BootModes
>> +pub enum BootMode {
>> + /// The BootMode is EFI/UEFI
>> + Efi,
>> + /// The BootMode is Legacy BIOS
>> + #[default]
> ^ do we *need* Default on this type? And why is Bios the default?
Removed it. Was enabled on the `NodeStatus` struct and cascaded down,
but afaik we can remove it
on the `NodeStatus` struct as well and get rid of it.
>
>> + LegacyBios,
>> +}
>> +
>> +#[api]
>> +#[derive(Serialize, Deserialize, Default)]
> And Clone
yep
>> +fn boot_mode_to_info(bm: boot_mode::BootModeInformation) -> BootModeInformation {
> I'd prefer the match to be a single level by doing
>
> use boot_mode::{BootModeIntofmation::*, SecureBoot};
> use pbs_api_types::BootMode;
> match bm {
> Efi(SecureBoot::Enabled) => BootModeInformation {
> ...
> mode: BootMode::Efi,
> secureboot: true,
> },
> Efi(SecureBoot::Disabled) => BootModeInformation {
> ...
> mode: BootMode::Efi,
> secureboot: false,
> },
> Bios => BootModeInformation {
> ...
> mode: BootMode::LegacyBios,
> secureboot: false,
> },
> }
>
> IMO that's easier to follow.
Good point!
next prev parent reply other threads:[~2023-11-27 13:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 10:52 [pbs-devel] [PATCH v4 proxmox{, -backup} 0/3] Add boot_mode, improve kernel version Gabriel Goller
2023-11-27 10:52 ` [pbs-devel] [PATCH v4 proxmox 1/3] sys: add function to get boot_mode Gabriel Goller
2023-11-27 13:08 ` Wolfgang Bumiller
2023-11-27 13:23 ` Gabriel Goller
2023-11-27 10:52 ` [pbs-devel] [PATCH v4 proxmox-backup 2/3] node: status: added bootmode Gabriel Goller
2023-11-27 13:10 ` Wolfgang Bumiller
2023-11-27 13:28 ` Gabriel Goller [this message]
2023-11-27 13:53 ` Wolfgang Bumiller
2023-11-27 14:02 ` Gabriel Goller
2023-11-29 8:58 ` Wolfgang Bumiller
2023-11-29 9:08 ` Gabriel Goller
2023-11-27 10:52 ` [pbs-devel] [PATCH v4 proxmox-backup 3/3] node: status: declutter kernel-version Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b073619-730b-4e39-affc-45cbc624ef7c@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox