Re: [pbs-devel] [PATCH proxmox{, -backup} v6 0/4] proxmox-log introduction

[Lukas Wagner <l.wagner@proxmox.com>]

On  2024-06-26 15:10, Gabriel Goller wrote:
> Removed the task_log! (and friends task_warn!, task_debug!, etc.) macro
> and introduced the `tracing` crate. We now initiate the tracing crate
> using two layer, which are logging to the syslog and the tasklog.
> It uses the `tracing-journald` crate and the original `FileLogger`.
> 
> To write to the task logs from the worker threads and tasks, we now
> have a task_local logger (and warning counter), which
> will get instantiated when a task/thread is created. This means that
> when we call `info!` or any other `tracing` log macros, it will get 
> the file_logger from TLS and write to the file.
> 
> v6, thanks @Lukas:
>  - rebase
>  - reorder imports, inline variables
>  - introduce `tracing-journald` and throw out `syslog`
>  - split single layer into two, one for syslog and for tasklog
> 
> 
> 
> Summary over all repositories:
>   46 files changed, 809 insertions(+), 1114 deletions(-)
> 

LGTM now.

Could you post a cargo fmt'd v7? There are
some whitespace errors (trailing spaces) and some minor
formatting issues, nothing major. Feel free to already
augment the following trailers to your v7 commits:

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>

-- 
- Lukas


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel