From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] upid: remove arbitrary 128 max length for UPID
Date: Fri, 24 Sep 2021 11:10:44 +0200 [thread overview]
Message-ID: <2abc2034-8c78-b2f2-d6c5-12391ccc3bfa@proxmox.com> (raw)
In-Reply-To: <20210923134732.1768609-1-d.csapak@proxmox.com>
applied to proxmox crate (upid is now in proxmox crate)
On 9/23/21 3:47 PM, Dominik Csapak wrote:
> we can easily go beyond that when having long datastore/remote names
> also because we do 'systemd-encode' them, which means that every special
> char takes up 4 bytes (e.g. '-' => '\x2d')
>
> while we could just increase the lenght to say 256 or 512, i do not
> really see the benefit to limit this at all, since users cannot create
> tasks with arbitrary names, and all other fields are generated from
> other valid types (username, datastore, remote, etc.)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> pbs-api-types/src/upid.rs | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/pbs-api-types/src/upid.rs b/pbs-api-types/src/upid.rs
> index ba23a646..3094be2d 100644
> --- a/pbs-api-types/src/upid.rs
> +++ b/pbs-api-types/src/upid.rs
> @@ -58,7 +58,6 @@ pub const PROXMOX_UPID_FORMAT: ApiStringFormat =
>
> pub const UPID_SCHEMA: Schema = StringSchema::new("Unique Process/Task Identifier")
> .min_length("UPID:N:12345678:12345678:12345678:::".len())
> - .max_length(128) // arbitrary
> .format(&PROXMOX_UPID_FORMAT)
> .schema();
>
prev parent reply other threads:[~2021-09-24 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 13:47 [pbs-devel] " Dominik Csapak
2021-09-24 9:10 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2abc2034-8c78-b2f2-d6c5-12391ccc3bfa@proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox