public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Stefan Reiter <s.reiter@proxmox.com>
Subject: [pbs-devel] applied: [PATCH v2 proxmox-backup 1/2] file-restore: increase lock timeout on QEMU map
Date: Tue, 13 Jul 2021 12:08:18 +0200	[thread overview]
Message-ID: <297db9c2-0644-2926-6cb3-512d33d5a92a@proxmox.com> (raw)
In-Reply-To: <20210713092321.597180-1-s.reiter@proxmox.com>

applied

On 7/13/21 11:23 AM, Stefan Reiter wrote:
> This lock is held during VM startup, so that multiple calls will not
> start VMs twice. But this means that the timeout needs to incorporate
> the time it might take a VM to boot, so increase it quite a bit.
>
> This could previously lead to "interrupted system call" errors when
> accessing backups with many disks.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> v2: unchanged
>
>   src/bin/proxmox_file_restore/block_driver_qemu.rs | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bin/proxmox_file_restore/block_driver_qemu.rs b/src/bin/proxmox_file_restore/block_driver_qemu.rs
> index 24f62796..46d91198 100644
> --- a/src/bin/proxmox_file_restore/block_driver_qemu.rs
> +++ b/src/bin/proxmox_file_restore/block_driver_qemu.rs
> @@ -50,7 +50,7 @@ impl VMStateMap {
>       /// Acquire a lock on the state map and retrieve a deserialized version
>       fn load() -> Result<Self, Error> {
>           let mut file = Self::open_file_raw(true)?;
> -        lock_file(&mut file, true, Some(std::time::Duration::from_secs(5)))?;
> +        lock_file(&mut file, true, Some(std::time::Duration::from_secs(120)))?;
>           let map = serde_json::from_reader(&file).unwrap_or_default();
>           Ok(Self { map, file })
>       }




      parent reply	other threads:[~2021-07-13 10:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  9:23 [pbs-devel] " Stefan Reiter
2021-07-13  9:23 ` [pbs-devel] [PATCH v2 proxmox-backup 2/2] fix #3515: file-restore-daemon: allow LVs/PVs with dash in name Stefan Reiter
2021-07-13 10:08   ` [pbs-devel] applied: " Dietmar Maurer
2021-07-13 10:08 ` Dietmar Maurer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=297db9c2-0644-2926-6cb3-512d33d5a92a@proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.reiter@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal