From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] auth: 'crypt' is not thread safe
Date: Mon, 12 Jul 2021 19:09:40 +0200 [thread overview]
Message-ID: <29128580-dfcc-2306-d68d-470fa64dbe2e@proxmox.com> (raw)
In-Reply-To: <20210712163047.3119673-1-s.reiter@proxmox.com>
On 12.07.21 18:30, Stefan Reiter wrote:
> According to crypt(3):
> "crypt places its result in a static storage area, which will be
> overwritten by subsequent calls to crypt. It is not safe to call crypt
> from multiple threads simultaneously."
>
> This means that multiple login calls as a PBS-realm user can collide and
> produce intermittent authentication failures. A visible case is for
> file-restore, where VMs with many disks lead to just as many auth-calls
> at the same time, as the GUI tries to expand each tree element on load.
>
> Instead, use the thread-safe variant 'crypt_r', which places the result
> into a pre-allocated buffer of type 'crypt_data'. The C struct is laid
> out according to 'lib/crypt.h.in' and the man page mentioned above.
>
> Use the opportunity and make both arguments to the rust 'crypt' function
> take a &[u8].
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> Easier solution would of course be to just wrap the call in a Mutex<()> or
> similar, but that comes at the cost of locking...
>
> src/auth.rs | 57 +++++++++++++++++++++++++++++++++++++++--------------
> 1 file changed, 42 insertions(+), 15 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-07-12 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 16:30 [pbs-devel] " Stefan Reiter
2021-07-12 17:09 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29128580-dfcc-2306-d68d-470fa64dbe2e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox