From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox{, -backup} 0/3] followups for PBS s3 backend
Date: Tue, 22 Jul 2025 22:25:21 +0200 [thread overview]
Message-ID: <28d503d6-53e6-42e2-9136-c53686c9fb16@proxmox.com> (raw)
In-Reply-To: <20250722163603.1520687-1-c.ebner@proxmox.com>
Am 22.07.25 um 18:36 schrieb Christian Ebner:
> These are followup patches to be applied on top of the patch series
> found here:
> https://lore.proxmox.com/pbs-devel/20250722101106.526438-1-c.ebner@proxmox.com/T/
>
> Most notably, they fix a regression introduced in version v11, as
> discovered by Lukas. The api now did incorrectly return also the secret
> key for s3 endpoint configurations.
>
> Further, there is a patch which checks bucket access during datastore
> creation already in the api, before spawning the datastore create task.
> By this, if the bucket cannot be accessed, the user is notified right
> away and does not need to re-enter all the datastore configurations.
>
> proxmox:
>
> Christian Ebner (1):
> s3 client: split config api type into 3 config structs
>
> proxmox-s3-client/src/api_types.rs | 62 ++++++++++++++++++++++++------
> proxmox-s3-client/src/client.rs | 3 +-
> 2 files changed, 52 insertions(+), 13 deletions(-)
>
> proxmox-backup:
>
> Christian Ebner (2):
> config: s3: adapt to new config struct layouts
> datastore: check s3 bucket access before create datastore task
>
> pbs-config/src/s3.rs | 7 ++--
> pbs-datastore/src/datastore.rs | 11 +++--
> src/api2/admin/s3.rs | 7 ++--
> src/api2/config/datastore.rs | 76 ++++++++++++++++++++++++----------
> src/api2/config/s3.rs | 65 ++++++++++++++++++++---------
> 5 files changed, 114 insertions(+), 52 deletions(-)
>
applied, thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-07-22 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 16:36 [pbs-devel] " Christian Ebner
2025-07-22 16:36 ` [pbs-devel] [PATCH proxmox 1/1] s3 client: split config api type into 3 config structs Christian Ebner
2025-07-22 16:36 ` [pbs-devel] [PATCH proxmox-backup 1/2] config: s3: adapt to new config struct layouts Christian Ebner
2025-07-22 16:36 ` [pbs-devel] [PATCH proxmox-backup 2/2] datastore: check s3 bucket access before create datastore task Christian Ebner
2025-07-22 20:25 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28d503d6-53e6-42e2-9136-c53686c9fb16@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox