From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] api: serde-rename deleteable properties to kebab-case
Date: Fri, 20 Jan 2023 08:48:23 +0100 [thread overview]
Message-ID: <283ad315-6d1b-d3a8-225f-f8628d00187f@proxmox.com> (raw)
In-Reply-To: <20230119155232.802404-1-l.wagner@proxmox.com>
Am 19/01/2023 um 16:52 schrieb Lukas Wagner:
> In former commit, the enum members were renamed to be CamelCase, in
> accordance with the usual Rust style guide. However, this broke the
> GUI in some places due to failing JSON property deserialization.
> To fix this, some serde(rename = "kebab-case") directives were added.
>
> Some properties were also serde-renamed to snake_case, otherwise
> it would have been necessary to also modify proxmox-widget-toolkit
> as well as PVE source code. This can follow in a later commit if so
> desired.
>
> Fixes: a2055c38 fix non-camel-case enums
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> src/api2/config/media_pool.rs | 1 +
> src/api2/config/remote.rs | 1 +
> src/api2/node/dns.rs | 1 +
> src/api2/node/network.rs | 5 ++++-
> 4 files changed, 7 insertions(+), 1 deletion(-)
>
>
applied, thanks!
Wonder if we could have some sane checks for catching that; e.g., a rust test that
reads a in-git saved schema and diffs it with the current one, with noting/warning
newly added properties and throwing an error if existing ones change, so that the
dev needs to record such changes explicitly with the patch they're modifying it, if
it's a wanted change that is.
prev parent reply other threads:[~2023-01-20 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 15:52 [pbs-devel] " Lukas Wagner
2023-01-20 7:48 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=283ad315-6d1b-d3a8-225f-f8628d00187f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox