Re: [pbs-devel] [PATCH v3 backup stable-2] pbs2to3: add upgrade checker binary

[Fiona Ebner <f.ebner@proxmox.com>]

Am 28.06.23 um 13:53 schrieb Christian Ebner:
> Adds the pbs2to3 upgrade checker with some basic checks.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---

Didn't give it an in-depth look, because of limited time, but:

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>

Potential for follow-up:

After upgrade, I got

WARN: a suitable kernel 'pve-kernel-6.2' is installed, but an unsuitable
'6.2.9-1-pve' is booted, missing reboot?!

which is a bit confusing because the booted one is a pve-kernel-6.2,
just not the newest ;)

> +
> +    fn check_repo_file(
> +        &mut self,
> +        found_suite: &mut Option<(String, String)>,
> +        mismatches: &mut Vec<(String, String)>,
> +        strange_suite: &mut bool,
> +        repo_file: APTRepositoryFile,
> +    ) -> Result<(), Error> {
> +        for repo in repo_file.repositories {
> +            if !repo.enabled || repo.types == [APTRepositoryPackageType::DebSrc] {
> +                continue;
> +            }
> +            for suite in &repo.suites {
> +                let suite = match suite.find(&['-', '/'][..]) {
> +                    Some(n) => &suite[0..n],
> +                    None => suite,
> +                };
> +
> +                if suite != OLD_SUITE && suite != NEW_SUITE {
> +                    let location = repo_file.path.clone().unwrap_or_default();
> +                    self.output.log_notice(format!(
> +                        "found unusual suite '{suite}', neighter old '{OLD_SUITE}' nor new \

typo: s/neighter/neither/