From: Gabriel Goller <g.goller@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v5 6/6] ui: add support for optional Remote in SyncJob
Date: Thu, 9 Nov 2023 10:34:42 +0100 [thread overview]
Message-ID: <262e08b9-b378-449e-9680-98f818edcad9@proxmox.com> (raw)
In-Reply-To: <20231006140529.723988-7-h.laimer@proxmox.com>
Hi!
I tested it a bit and it looks good so far, a few small ui issues though:
* When listing the sync-jobs, a local sync job has an empty 'Remote ID',
which
doesn't look that good. We could add a defaultValue that shows
'Local' or
something?
* We don't support syncs from and to the same datastore, so it also
shouldn't be
allowed to select it in the ui. Currently all the datastores are
shown on the
dropdown. These syncs also run successfully but don't sync
anything, we should
probably throw an error in the api if such a sync is requested. So
that ui and
api disallow same-datastore syncs.
On 10/6/23 16:05, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> www/form/RemoteTargetSelector.js | 29 ++++++++-----
> www/window/SyncJobEdit.js | 72 +++++++++++++++++++++++++++++++-
> 2 files changed, 90 insertions(+), 11 deletions(-)
> [..]
prev parent reply other threads:[~2023-11-09 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 14:05 [pbs-devel] [PATCH proxmox-backup v5 0/6] local sync-jobs Hannes Laimer
2023-10-06 14:05 ` [pbs-devel] [PATCH proxmox-backup v5 1/6] api: make Remote for SyncJob optional Hannes Laimer
2023-11-08 10:53 ` Thomas Lamprecht
2023-11-08 13:26 ` Hannes Laimer
2023-10-06 14:05 ` [pbs-devel] [PATCH proxmox-backup v5 2/6] manager: add completion for opt. Remote in SyncJob Hannes Laimer
2023-10-06 14:05 ` [pbs-devel] [PATCH proxmox-backup v5 3/6] accept a ref to a HttpClient Hannes Laimer
2023-10-06 14:05 ` [pbs-devel] [PATCH proxmox-backup v5 4/6] pull: refactor pulling from a datastore Hannes Laimer
2023-10-06 14:05 ` [pbs-devel] [PATCH proxmox-backup v5 5/6] pull: add support for pulling from local datastore Hannes Laimer
2023-10-06 14:05 ` [pbs-devel] [PATCH proxmox-backup v5 6/6] ui: add support for optional Remote in SyncJob Hannes Laimer
2023-11-08 11:06 ` Thomas Lamprecht
2023-11-09 9:34 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=262e08b9-b378-449e-9680-98f818edcad9@proxmox.com \
--to=g.goller@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox