From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] upload_chunk: allow upload of empty blobs
Date: Tue, 28 Jul 2020 11:05:03 +0200 (CEST) [thread overview]
Message-ID: <260669461.258.1595927104275@webmail.proxmox.com> (raw)
In-Reply-To: <20200727112226.10715-1-d.csapak@proxmox.com>
applied
> On 07/27/2020 1:22 PM Dominik Csapak <d.csapak@proxmox.com> wrote:
>
>
> a blob can be empty (e.g. an empty pct fw conf), so we
> have to set the minimum size to the header size
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> fixes the problem some users had, e.g.
> https://forum.proxmox.com/threads/ct-backup-error-parameter-encoded-size-value-must-have-a-minimum-value-of-13-got-12.73051/
>
> src/api2/backup/upload_chunk.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/api2/backup/upload_chunk.rs b/src/api2/backup/upload_chunk.rs
> index 483ced3..ec95472 100644
> --- a/src/api2/backup/upload_chunk.rs
> +++ b/src/api2/backup/upload_chunk.rs
> @@ -243,7 +243,7 @@ pub const API_METHOD_UPLOAD_BLOB: ApiMethod = ApiMethod::new(
> &sorted!([
> ("file-name", false, &crate::api2::types::BACKUP_ARCHIVE_NAME_SCHEMA),
> ("encoded-size", false, &IntegerSchema::new("Encoded blob size.")
> - .minimum((std::mem::size_of::<DataBlobHeader>() as isize) +1)
> + .minimum(std::mem::size_of::<DataBlobHeader>() as isize)
> .maximum(1024*1024*16+(std::mem::size_of::<EncryptedDataBlobHeader>() as isize))
> .schema()
> )
> --
> 2.20.1
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2020-07-28 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 11:22 [pbs-devel] " Dominik Csapak
2020-07-28 9:05 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=260669461.258.1595927104275@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox