From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] gui: remove document.execCommand calls
Date: Thu, 14 Mar 2024 08:59:46 +0100 [thread overview]
Message-ID: <2524761d-e6b9-4d89-84ef-03d261029f92@proxmox.com> (raw)
In-Reply-To: <20240313161801.132483-1-g.goller@proxmox.com>
hi,
just to note: changing to an async function can be rather dangerous,
sometimes extjs not only calls the handlers/events/etc. but does things
after them (expecting the function to be finished) or waits for the return value.
(most of the extjs code was from before async/await was a thing in js)
so here it seems to work out fine, but we have to be careful with
sprinkling async function in the code, otherwise we'll get
very unexpected results
in general, i'd like to see that mentioned in the commit message
why it's ok to do that (no hard feelings though)
otherwise LGTM
next prev parent reply other threads:[~2024-03-14 8:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 16:17 Gabriel Goller
2024-03-13 16:17 ` [pbs-devel] [PATCH proxmox-backup 2/2] fix #5188: gui: add copy to clipboard on snapshots Gabriel Goller
2024-03-14 8:01 ` Dominik Csapak
2024-03-14 9:10 ` Gabriel Goller
2024-03-14 7:59 ` Dominik Csapak [this message]
2024-03-14 9:08 ` [pbs-devel] [PATCH proxmox-backup 1/2] gui: remove document.execCommand calls Gabriel Goller
2024-03-14 9:13 ` Dominik Csapak
2024-03-14 9:21 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2524761d-e6b9-4d89-84ef-03d261029f92@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox