public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] fix #4971: client: Improve output on successful snapshot deletion
@ 2023-10-03 14:07 Philipp Hufnagl
  2023-10-12 13:07 ` Dominik Csapak
  2023-10-13 11:30 ` Thomas Lamprecht
  0 siblings, 2 replies; 6+ messages in thread
From: Philipp Hufnagl @ 2023-10-03 14:07 UTC (permalink / raw)
  To: pbs-devel

When a snapshot gets deleted (forgotten), the proxmox backup client
currently returns returns
"Result: {
  "data": null
}"

This feedback may confuse users therefore this patch changes the output
to

"Successfully deleted snapshot <snapshot>"

Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
---
 proxmox-backup-client/src/snapshot.rs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/proxmox-backup-client/src/snapshot.rs b/proxmox-backup-client/src/snapshot.rs
index 4ca8015f..1d985a2e 100644
--- a/proxmox-backup-client/src/snapshot.rs
+++ b/proxmox-backup-client/src/snapshot.rs
@@ -188,13 +188,14 @@ async fn forget_snapshots(param: Value) -> Result<Value, Error> {
 
     let path = format!("api2/json/admin/datastore/{}/snapshots", repo.store());
 
-    let result = client
+    client
         .delete(&path, Some(snapshot_args(&backup_ns, &snapshot)?))
         .await?;
 
     record_repository(&repo);
 
-    Ok(result)
+    println!("Successfully deleted snapshot {}", snapshot);
+    Ok(Value::Null)
 }
 
 #[api(
-- 
2.39.2





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-10-16 10:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-03 14:07 [pbs-devel] [PATCH proxmox-backup] fix #4971: client: Improve output on successful snapshot deletion Philipp Hufnagl
2023-10-12 13:07 ` Dominik Csapak
2023-10-13 11:30 ` Thomas Lamprecht
2023-10-13 14:57   ` Philipp Hufnagl
2023-10-13 16:29     ` Thomas Lamprecht
2023-10-16 10:48       ` Philipp Hufnagl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal