From: Christian Ebner <c.ebner@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/3] sync: pull: do not resync currently newest snapshot on target
Date: Mon, 4 Nov 2024 13:20:30 +0100 [thread overview]
Message-ID: <23f19edf-7865-4d32-b185-a93458b40f83@proxmox.com> (raw)
In-Reply-To: <1730722172.za02ajxxfy.astroid@yuna.none>
On 11/4/24 13:15, Fabian Grünbichler wrote:
> On November 4, 2024 11:58 am, Christian Ebner wrote:
>> The currently newest snapshot of a group on the sync target is not
>> excluded from the list of already synced snapshots, leading to a
>> re-sync.
>
> this is intentional, the last snapshot might not have been completely
> done on the source side when we last synced it (e.g., backup log still
> missing, post-backup verification not done yet, ..).
Ah I see, thanks for clarification: was already expecting this to be
more subtle.
Will amend the patch to explicitly mention this as a comment.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-04 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 10:58 [pbs-devel] [PATCH proxmox-backup 1/3] sync: fix premature return in snapshot skip filter logic Christian Ebner
2024-11-04 10:58 ` [pbs-devel] [PATCH proxmox-backup 2/3] sync: pull: do not resync currently newest snapshot on target Christian Ebner
2024-11-04 12:15 ` Fabian Grünbichler
2024-11-04 12:20 ` Christian Ebner [this message]
2024-11-04 10:58 ` [pbs-devel] [PATCH proxmox-backup 3/3] sync: pull: simplify logic for source snapshot filtering Christian Ebner
2024-11-04 12:15 ` Fabian Grünbichler
2024-11-04 12:15 ` [pbs-devel] partially-applied: [PATCH proxmox-backup 1/3] sync: fix premature return in snapshot skip filter logic Fabian Grünbichler
2024-11-04 12:57 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23f19edf-7865-4d32-b185-a93458b40f83@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox