public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox v3 1/3] pbs-api-types: use proxmox-network-api types
Date: Thu, 31 Jul 2025 10:14:56 +0200	[thread overview]
Message-ID: <22b684b4-1c32-478b-83aa-08fd6ba5a283@proxmox.com> (raw)
In-Reply-To: <20250730155157.363596-3-s.hanreich@proxmox.com>

Hi,

I think this patch still misses adaptions to 
`pbs-api-types/src/traffic_control.rs`, which used `crate::CIDR_SCHEMA` 
and should drop `mod network` and its pub export in 
`pbs-api-types/src/lib.rs` as well.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2025-07-31  8:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30 15:51 [pbs-devel] [PATCH proxmox{-ve-rs, , -backup, -firewall, -network-interface-pinning} v3 0/8] proxmox-network-interface-pinning Stefan Hanreich
2025-07-30 15:51 ` [pbs-devel] [PATCH proxmox-ve-rs v3 1/1] host: network: move to proxmox-network-api Stefan Hanreich
2025-07-30 15:51 ` [pbs-devel] [PATCH proxmox v3 1/3] pbs-api-types: use proxmox-network-api types Stefan Hanreich
2025-07-31  8:14   ` Christian Ebner [this message]
2025-07-31  8:19     ` Stefan Hanreich
2025-07-30 15:51 ` [pbs-devel] [PATCH proxmox v3 2/3] proxmox-network-api: use ip link for querying interface information Stefan Hanreich
2025-07-30 15:51 ` [pbs-devel] [PATCH proxmox v3 3/3] network-api: add rename_interfaces method Stefan Hanreich
2025-07-30 15:51 ` [pbs-devel] [PATCH proxmox-backup v3 1/2] config: network: move to proxmox-network-api Stefan Hanreich
2025-07-30 15:51 ` [pbs-devel] [PATCH proxmox-backup v3 2/2] metric_collection: use ip link for determining the type of interfaces Stefan Hanreich
2025-07-30 15:51 ` [pbs-devel] [PATCH proxmox-firewall v3 1/1] firewall: config: use proxmox-network-api Stefan Hanreich
2025-07-30 15:51 ` [pbs-devel] [PATCH proxmox-network-interface-pinning v3 1/1] initial commit Stefan Hanreich
2025-07-31 10:19 ` [pbs-devel] [PATCH proxmox{-ve-rs, , -backup, -firewall, -network-interface-pinning} v3 0/8] proxmox-network-interface-pinning Christian Ebner
2025-07-31 10:58   ` Stefan Hanreich
2025-07-31 12:55 ` Christian Ebner
2025-07-31 14:18 ` [pbs-devel] superseded: " Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22b684b4-1c32-478b-83aa-08fd6ba5a283@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal