From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] api: create_datastore: fix nesting checks
Date: Wed, 27 Nov 2024 14:23:59 +0100 [thread overview]
Message-ID: <22373833-a743-47cc-bf24-c82847ab3e87@proxmox.com> (raw)
In-Reply-To: <20241127130521.1019765-1-f.gruenbichler@proxmox.com>
Am 27.11.24 um 14:05 schrieb Fabian Grünbichler:
> there two kinds of overlap we need to check here:
> - two removable datastores backed by the same device must not have nested
> relative paths on the device
> - any two datastores must not have nested absolute paths
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> src/api2/config/datastore.rs | 25 +++++++++++++++++--------
> 1 file changed, 17 insertions(+), 8 deletions(-)
>
>
applied, thanks!
FWIW, switching the "store" loop variable to something like "existing_store"
and "datastore" to "new_store" would help on reading here.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-27 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 13:05 [pbs-devel] " Fabian Grünbichler
2024-11-27 13:23 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22373833-a743-47cc-bf24-c82847ab3e87@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox