From: Mira Limbeck <m.limbeck@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 0/2] add support for HttpOnly cookies for OpenID authentication flow
Date: Thu, 7 Aug 2025 14:17:18 +0200 [thread overview]
Message-ID: <2192cf28-8da4-4054-93a9-5cd859f83d9e@proxmox.com> (raw)
In-Reply-To: <20250807120308.257071-2-s.sterz@proxmox.com>
On 8/7/25 14:02, Shannon Sterz wrote:
> these two patches do the following:
>
> 1. add a `http-only` parameter to the OpenID login endpoint, so clients
> can opt into receive the authentication ticket via a HttpOnly cookie
> 2. opt the ui dialog into using this new HttpOnly parameter
>
> this should fix a bug where users were instantly logged out again after
> a successful OpenID authentication.
>
> changes since v1, thanks @ Mira Limbeck:
>
> - fixed an issue where the open id login endpoint would return a
> `ticket_info` field instead of a `ticket-info` field.
>
> Shannon Sterz (2):
> api: openid: allow users of openid to opt into the HttpOnly cookies
> ui: opt open id authentication flows into the new http only flow
>
> src/api2/access/openid.rs | 346 ++++++++++++++++++++++----------------
> www/LoginView.js | 1 +
> 2 files changed, 206 insertions(+), 141 deletions(-)
>
> --
> 2.47.2
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
Gave this a quick test. Looks good!
Both cookies are now set.
Consider this:
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-08-07 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 12:03 Shannon Sterz
2025-08-07 12:03 ` [pbs-devel] [PATCH proxmox-backup v2 1/2] api: openid: allow users of openid to opt into the HttpOnly cookies Shannon Sterz
2025-08-07 12:03 ` [pbs-devel] [PATCH proxmox-backup v2 2/2] ui: opt open id authentication flows into the new http only flow Shannon Sterz
2025-08-07 12:17 ` Mira Limbeck [this message]
2025-08-07 12:53 ` [pbs-devel] [PATCH proxmox-backup v2 0/2] add support for HttpOnly cookies for OpenID authentication flow Maximiliano Sandoval
2025-08-07 16:58 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2192cf28-8da4-4054-93a9-5cd859f83d9e@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox