public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] file-restore: use 'norecovery' for xfs filesystem
@ 2021-04-29  8:22 Stefan Reiter
  2021-04-29 13:09 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Reiter @ 2021-04-29  8:22 UTC (permalink / raw)
  To: pbs-devel

This allows mounting XFS partitons with 'dirty' states, like from a
running VM. Otherwise XFS tries to write recovery information, which
fails on a read-only mount.

Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---

Gave it a spin myself now too, works fine.

 src/bin/proxmox_restore_daemon/disk.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/bin/proxmox_restore_daemon/disk.rs b/src/bin/proxmox_restore_daemon/disk.rs
index 0b564e42..b0d5f72d 100644
--- a/src/bin/proxmox_restore_daemon/disk.rs
+++ b/src/bin/proxmox_restore_daemon/disk.rs
@@ -25,6 +25,8 @@ lazy_static! {
         m.insert("ext3", "noload");
         m.insert("ext4", "noload");
 
+        m.insert("xfs", "norecovery");
+
         // ufs2 is used as default since FreeBSD 5.0 released in 2003, so let's assume that
         // whatever the user is trying to restore is not using anything older...
         m.insert("ufs", "ufstype=ufs2");
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup] file-restore: use 'norecovery' for xfs filesystem
  2021-04-29  8:22 [pbs-devel] [PATCH proxmox-backup] file-restore: use 'norecovery' for xfs filesystem Stefan Reiter
@ 2021-04-29 13:09 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-04-29 13:09 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Stefan Reiter

On 29.04.21 10:22, Stefan Reiter wrote:
> This allows mounting XFS partitons with 'dirty' states, like from a
> running VM. Otherwise XFS tries to write recovery information, which
> fails on a read-only mount.
> 
> Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
> 
> Gave it a spin myself now too, works fine.
> 
>  src/bin/proxmox_restore_daemon/disk.rs | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-29 13:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29  8:22 [pbs-devel] [PATCH proxmox-backup] file-restore: use 'norecovery' for xfs filesystem Stefan Reiter
2021-04-29 13:09 ` [pbs-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal