Re: [pbs-devel] [PATCH pxar] encoder: flush after writing last entry

[Dietmar Maurer <dietmar@proxmox.com>]

> > +        flush(self.output.as_mut()).await?;
> 
> According to the patch comment this hasn't broken anywhere at the time,
> but was there any test-code that did need this?
> 
> I'd like to make this at least conditional on the writer being
> `EncoderOutput::Owned` to not cause additional flushes for every single
> level of directory nesting.

Oh, I was not aware that this calls flush for every directory. I guess
nobody really wants that.

> That said, I'm not even convinced an `Owned` writer would really need
> this? You don't need to explicitly call `flush()` on a `std::fs::File`
> or even a `std::io::BufWriter` explicitly (`BufWriter` explicitly
> flushes in its `Drop` handler), unless you *explicitly* want to handle
> its error, but then you should keep ownership of the writer you pass to
> the encoder anyway and flush manually, not leave that up to the pxar
> code.

I am ok with reverting this patch.