From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Stefan Lendl <s.lendl@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 0/8] *** SUBJECT HERE ***
Date: Thu, 21 Mar 2024 11:24:40 +0100 [thread overview]
Message-ID: <20ceb8c8-fb04-4e5b-a22b-f3141f17af4d@proxmox.com> (raw)
In-Reply-To: <20240208135953.2078165-1-s.lendl@proxmox.com>
On 2024-02-08 14:59, Stefan Lendl wrote:
> *** BLURB HERE ***
>
> Stefan Lendl (8):
> api: garbage collect job status
> gc: global prune and gc job view
> gc: move datastore/PruneAndGC to config/PruneAndGC
> gc: hide datastore column in local gc view
> ui: order Prune&GC before SyncJobs
> cli: list gc jobs with proxmox-backup-manager
> gc: show removed and pending chunks of last run in ui
> gc: configure width and flex on GC Jobs columns
>
> pbs-api-types/src/datastore.rs | 40 +++++
> src/api2/admin/datastore.rs | 129 +++++++++++++++-
> src/api2/admin/gc.rs | 57 +++++++
> src/api2/admin/mod.rs | 2 +
> src/bin/proxmox-backup-manager.rs | 33 ++++
> www/Makefile | 4 +-
> www/Utils.js | 6 +-
> www/config/GCView.js | 243 ++++++++++++++++++++++++++++++
> www/config/PruneAndGC.js | 52 +++++++
> www/datastore/DataStoreList.js | 11 +-
> www/datastore/Panel.js | 3 +-
> www/datastore/PruneAndGC.js | 133 ----------------
> www/window/GCJobEdit.js | 28 ++++
> 13 files changed, 593 insertions(+), 148 deletions(-)
> create mode 100644 src/api2/admin/gc.rs
> create mode 100644 www/config/GCView.js
> create mode 100644 www/config/PruneAndGC.js
> delete mode 100644 www/datastore/PruneAndGC.js
> create mode 100644 www/window/GCJobEdit.js
>
Apart from the requested change from chunks to bytes, these
changes look good to me :)
Please make sure to include the cover letter in v4 ;)
With the suggested UI/API changes, consider this:
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
--
- Lukas
next prev parent reply other threads:[~2024-03-21 10:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 13:59 Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 1/8] api: garbage collect job status Stefan Lendl
2024-03-21 10:23 ` Lukas Wagner
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 2/8] gc: global prune and gc job view Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 3/8] gc: move datastore/PruneAndGC to config/PruneAndGC Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 4/8] gc: hide datastore column in local gc view Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 5/8] ui: order Prune&GC before SyncJobs Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 6/8] cli: list gc jobs with proxmox-backup-manager Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 7/8] gc: show removed and pending chunks of last run in ui Stefan Lendl
2024-02-08 13:59 ` [pbs-devel] [PATCH v3 proxmox-backup 8/8] gc: configure width and flex on GC Jobs columns Stefan Lendl
2024-02-21 9:56 ` [pbs-devel] [PATCH v3 proxmox-backup 0/8] Add GC job status to datastore and global prune job view Stefan Lendl
2024-02-21 9:58 ` Stefan Lendl
2024-03-07 13:16 ` Stefan Lendl
2024-03-21 10:24 ` Lukas Wagner [this message]
2024-04-04 13:53 ` [pbs-devel] [PATCH v3 proxmox-backup 0/8] *** SUBJECT HERE *** Stefan Lendl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20ceb8c8-fb04-4e5b-a22b-f3141f17af4d@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.lendl@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox