public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox v2 0/3] fix #8341: reduce task list lock contention during old task log cleanup
Date: Fri, 20 Nov 2026 09:27:07 +0100	[thread overview]
Message-ID: <20261120082710.65728-1-c.ebner@proxmox.com> (raw)

When rotating the task log archive and cleaning up old task logs
(scheduled daily at midnight in Proxmox Backup Server), and exclusive
lock was previously held for the entire duration of the cleanup.

On systems with a large number of task logs or slow storage,
directory traversal during task log cleanup can easily exceed the
15 second lock acquisition timeout. Because state updates on any
worker task requires an exclusive lock on `.active.lock` to update the
active task list, tasks running concurrently around midnight failed
with:
```
Unable to acquire lock "/var/log/proxmox-backup/tasks/.active.lock" - Interrupted system call (os error 4)
```

Since determining the cutoff timestamp only requires reading the
oldest entry from the task archive and is not required at all when
removing the log files for which mtime is older than the cutoff time,
acquire a shared lock only and drop it after the cutoff time has been
calculated.

Link to the bugtracker:
https://bugzilla.proxmox.com/show_bug.cgi?id=8341

Further cleanups are suggested in https://bugzilla.proxmox.com/show_bug.cgi?id=5960
are not part of this series.

Changes since version 1 (thanks a lot @Robert for feedback):
- Dropped patch changing error message since the signal interrupting the flock
  call can be unrelated to the timeout.
- Pull the latest active task gathering out of the loop which checks the
  finished tasks end time. This was needless to be repeated for each finished
  task as the active task list is still locked from being updated anyways.


proxmox:

Christian Ebner (3):
  rest-server: use shared instead of exclusive lock for old task cleanup
  fix #8341: rest-server: do not lock task list during old log cleanup
  rest-server: clamp old task log cleanup cutoff to earliest active task

 proxmox-rest-server/src/worker_task.rs | 68 +++++++++++++++++---------
 1 file changed, 44 insertions(+), 24 deletions(-)


Summary over all repositories:
  1 files changed, 44 insertions(+), 24 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-11-20  8:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  8:27 Christian Ebner [this message]
2026-11-20  8:27 ` [PATCH proxmox v2 1/3] rest-server: use shared instead of exclusive lock for old task cleanup Christian Ebner
2026-11-20  8:27 ` [PATCH proxmox v2 2/3] fix #8341: rest-server: do not lock task list during old log cleanup Christian Ebner
2026-11-20  8:27 ` [PATCH proxmox v2 3/3] rest-server: clamp old task log cleanup cutoff to earliest active task Christian Ebner
2026-11-20 13:51   ` Samuel Rufinatscha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120082710.65728-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal