From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup] pbs-key-config: ensure password-protected key is long enough
Date: Thu, 5 Nov 2026 12:07:25 +0100 [thread overview]
Message-ID: <20261105110750.805444-1-f.gruenbichler@proxmox.com> (raw)
while openssl fails if provided an empty slice, the resulting error message
points at the password instead of the key. checking for at least one byte of
data ensures plain and password-protected keys are distinguished.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
pbs-key-config/src/lib.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pbs-key-config/src/lib.rs b/pbs-key-config/src/lib.rs
index 7b87b4ea9..0cffdf008 100644
--- a/pbs-key-config/src/lib.rs
+++ b/pbs-key-config/src/lib.rs
@@ -211,7 +211,7 @@ impl KeyConfig {
let derived_key = kdf.derive_key(&passphrase)?;
- if raw_data.len() < 32 {
+ if raw_data.len() < EXPECTED_KEY_LEN + 1 {
bail!("Unable to decrypt key - short data");
}
let iv = &raw_data[0..16];
--
2.47.3
reply other threads:[~2026-11-05 11:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261105110750.805444-1-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox